Skip to content

Fix #3320: detect dynamic await in pre-Roslyn state machines #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siegfriedpammer merged 1 commit into from
Sep 15, 2026
Merged

Fix #3320: detect dynamic await in pre-Roslyn state machines #4132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ICSharpCode.Decompiler.Tests/ILPrettyTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ public void AllFilesHaveTests()
}
}

[Test]
public async Task Issue3320()
{
await Run();
}

[Test]
public async Task ConditionalChain()
{
Expand Down
2 changes: 1 addition & 1 deletion ICSharpCode.Decompiler.Tests/PrettyTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ public async Task DynamicTests([ValueSource(nameof(defaultOptions))] CompilerOpt
}

[Test]
public async Task DynamicAwait([ValueSource(nameof(roslynOnlyOptions))] CompilerOptions cscOptions)
public async Task DynamicAwait([ValueSource(nameof(defaultOptions))] CompilerOptions cscOptions)
{
await RunForLibrary(cscOptions: cscOptions);
}
Expand Down
22 changes: 22 additions & 0 deletions ICSharpCode.Decompiler.Tests/TestCases/ILPretty/Issue3320.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
using System.Threading.Tasks;

public interface IDapperAsyncImplementor
{
Task<T> GetAsync<T>(IDbConnection connection, object id, IDbTransaction transaction, int? commandTimeout) where T : class;
}
public interface IDbConnection
{
}
public interface IDbTransaction
{
}
public static class Issue3320
{
public static IDapperAsyncImplementor Instance => null;

public static async Task<T> GetAsync<T>(this IDbConnection connection, dynamic id, IDbTransaction transaction = null, int? commandTimeout = null) where T : class
{
dynamic async = Instance.GetAsync<T>(connection, id, transaction, commandTimeout);
return await async;
}
}
Loading
Loading