Make formatter in Markd#render optional - #101
Merged
Merged
Conversation
| def code_block(node : Node, entering : Bool, formatter : T?) : Nil forall T | ||
| {% if @top_level.has_constant?("Tartrazine") %} | ||
| def code_block(node : Node, entering : Bool, formatter : T? = nil) : Nil forall T | ||
| {% if @top_level.has_constant?("Tartrazine") && !formatter.nil? %} |
Contributor
There was a problem hiding this comment.
issue: This condition is wrong. formatter is a runtime parameter, we cannot check its value in a macro expression. This blows as soon as @top_level.has_constant?("Tartrazine") returns true (but it goes unnoticed without because macro expressions evaluate lazily).
Apparently there is no test case covering the code path when Tartrazine is available?
Contributor
Author
There was a problem hiding this comment.
This condition is wrong. formatter is a runtime parameter, we cannot check its value in a macro expression
I notice this, but, there is no error when I run spec, I will add it.
Contributor
Author
There was a problem hiding this comment.
Please check #102, @straight-shoota @icyleaf
zw963
added a commit
to zw963/markd
that referenced
this pull request
Aug 27, 2026
zw963
added a commit
to zw963/markd
that referenced
this pull request
Aug 27, 2026
zw963
added a commit
to zw963/markd
that referenced
this pull request
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check b3302f4#r197002531