Skip to content

Upgrade to Ruby 3.4.9, harden AMQP/HTTP stack, resolve all lint#141

Open
ipublic wants to merge 14 commits into
trunkfrom
ruby_3.4.9_upgrade
Open

Upgrade to Ruby 3.4.9, harden AMQP/HTTP stack, resolve all lint#141
ipublic wants to merge 14 commits into
trunkfrom
ruby_3.4.9_upgrade

Conversation

@ipublic
Copy link
Copy Markdown
Member

@ipublic ipublic commented May 1, 2026

Summary

Comprehensive upgrade and hardening of the EventSource gem:

  • Ruby 3.4.9 upgrade — update .ruby-version, resolve compatibility issues with Faraday 2.x, deep_merge, and dry-* gems
  • AMQP consumer safety — replace rescue Exception with targeted rescue (StandardError, ScriptError, SystemStackError, NoMemoryError) in BunnyConsumerHandler so subscriber bugs reject individual messages instead of crashing the consumer thread and losing all queued messages, while still allowing process lifecycle signals (SystemExit, Interrupt, SignalException) to propagate for clean shutdown
  • HTTP queue subsystem — harden FaradayRequestProxy and FaradayQueueProxy for Faraday 2.x API changes
  • Integration tests — new BunnyConsumerHandler integration specs against live RabbitMQ verifying failed messages are rejected, remaining queued messages survive, and process signals propagate
  • Test suite optimization — scope RabbitMQ connection setup to live-test contexts only, reducing suite time from 80s to 26s; fix subscriber doubles missing executable_for stubs; reduce drain timeout values in cancel_consumers specs
  • Test coverage expansion — new specs for BunnyConsumerProxy, BunnyMessageProxy, Queue, WorkerPool, AMQP contracts, error classes, and types; extensive spec expansion for channel/connection/queue/exchange proxies (both AMQP and HTTP)
  • Rubocop: 347 → 0 offenses — auto-correct + manual fixes across 84 files; extract shared SessionConcern to spec/support/; refactor SnsPublisherProxy#publish; add Style/Documentation comments to 17 modules/classes; configure node_modules exclusion
  • YARD docs: 0 warnings — fix all @param mismatches, suppress dynamic mixin warnings via send(:include, ...), exclude rspec/ and railtie.rb from docs, fix stale class descriptions
  • README rewrite — clearer structure, AsyncAPI-as-API framing, aca_entities schema directory listing, configuration/exception handling/development sections
  • Protocols architecture overview — new module-level documentation covering adapter/facade patterns, proxy class hierarchy, ASCII architecture diagram, and step-by-step guide for adding new protocols
  • CI workflow — upgrade actions/checkout v2→v4 and actions/cache v4→v5 to resolve Node.js 20 deprecation warnings
  • Version bump — 0.6.0 → 0.7.0
  • event_spec cleanup — remove commented-out code, consolidate duplicate class definitions, activate valid tests, prune broken ones

Test plan

  • bundle exec rspec — 553 examples, 0 failures, 0 pending (26s)
  • bundle exec rubocop — 296 files inspected, no offenses detected
  • bundle exec yard doc — 0 warnings, 73% documented
  • Integration tests pass against live RabbitMQ (Docker Compose)
  • Verify RabbitMQ integration tests pass in CI environment
  • Smoke test in downstream service (enroll) with updated Gemfile reference

harshaellanki and others added 11 commits March 2, 2026 16:10
…stem

- Bump Ruby from 3.2.1 to 3.4.9; update CI matrix to [3.2.2, 3.3.8, 3.4.9]
- Migrate Faraday 1.4 to 2.x (CVE-2026-25765): replace build_response
  with run_request, swap faraday_middleware for faraday-retry
- Relax pinned dry-types/dry-validation/dry-schema upper bounds
- Fix Queue: add explicit empty?/size methods (was method_missing chain)
- Fix Worker: graceful shutdown with join+timeout, per-action error
  isolation, cache resolved actions at thread spawn
- Fix logger.warning -> logger.warn in faraday_channel_proxy (NoMethodError)
- Add YARD documentation to Queue, Worker, and WorkerPool
- Add docker-compose.yml for local RabbitMQ
- Expand HTTP test suite from ~16 to 83 examples across connection,
  channel, request, and queue proxy specs
- Add new spec files: queue_spec (22), worker_spec (13), worker_pool_spec (10)
- Full suite: 340 examples, 0 failures
Bug fixes:
- Fix fatal typo `attribure` -> `attribute` in ChannelBinding struct
- Fix `athentication` -> `authentication` in connection error message
- Fix OptionDefaults protocol_version '1.9.1' -> '0.9.1' (AMQP 0-9-1)
- Fix `ErrorInitalizer` -> `ErrorInitializer` module name
- Fix duplicate :correlation_id in BunnyExchangeProxy#sanitize_bindings
- Fix empty respond_to_missing? across all 5 proxy classes
- Remove dead resolve_subscriber_routing_keys method
- Remove redundant rubocop:disable for Lint/UriEscapeUnescape

Documentation:
- Add YARD docs to all 15 AMQP source files

Test coverage (28 -> 238 examples):
- BunnyConnectionProxy: 6 -> 62 (stubbed unit tests for all methods)
- BunnyChannelProxy: 2 -> 49 (full DSL coverage)
- BunnyQueueProxy: 10 -> 61 (subscribe, decode, find_executable)
- Contracts: 4 -> 26 (add validation failure cases)
- New specs: consumer_proxy, message_proxy, error, types

Full suite: 548 examples, 0 failures
- Channels::Open: replace pending with test verifying unimplemented state
- Event: drop pending ContractNotDefined spec (error class doesn't exist)
- BunnyChannelProxy: drop pending auto-recovery (covered by new unit tests)
- BunnyConnectionProxy: drop broken invalid-creds integration test
  (covered by new stubbed auth failure tests)
- BunnyQueueProxy: drop 5 pending subscribe result specs (describe
  return codes and devops signals that don't exist in implementation)

Full suite: 540 examples, 0 failures, 0 pending
…ndler

rescue Exception swallowed SystemExit, Interrupt, and SignalException,
preventing clean process shutdown in containerized environments. Changed
to rescue StandardError, ScriptError, SystemStackError, NoMemoryError —
preserving protection against subscriber bugs (stack overflow, load
errors) while letting process lifecycle signals propagate.

Added 9 integration specs against live RabbitMQ verifying:
- non-StandardError exceptions reject the message without killing the consumer
- remaining queued messages survive subscriber exceptions
- Interrupt, SystemExit, and SignalException propagate for clean shutdown

Also pins parallel gem to 1.28.0 (2.1.0 requires Ruby >= 3.3).
Resolve all rubocop offenses across files changed in this branch (43
Ruby files, 0 offenses). Key changes:

- Auto-corrected 91 style offenses (lambda syntax, block delimiters,
  redundant exceptions, alignment, quoted symbols)
- Moved constants above `private` in BunnyConnectionProxy to fix
  Lint/UselessConstantScoping
- Extracted on_receive_message helper methods in BunnyQueueProxy to
  satisfy Metrics/MethodLength
- Added super() call in FaradayChannelProxy#initialize
- Cleaned up event_spec.rb: removed stale commented-out code, activated
  2 valid tests (missing publisher_path, attribute setter), pruned 3
  broken tests, added system_account to SessionConcern test double,
  consolidated MyCustomEvent with other test classes
Rewrite README with clearer structure, AsyncAPI-as-API framing, and
aca_entities schema directory listing. Add architectural overview to
Protocols module documenting adapter/facade patterns, proxy hierarchy,
and new-protocol guide. Fix all YARD warnings: suppress dynamic mixin
warnings via send(:include, ...), correct @param mismatches, exclude
rspec/railtie from docs, fix stale Config class description, remove
missing ChangeLog.md from .yardopts.
Auto-correct 231 offenses and manually fix 116. Key changes:
- Add Style/Documentation comments to 17 undocumented modules/classes
- Extract shared SessionConcern to spec/support, remove 5 duplicates
- Refactor SnsPublisherProxy#publish to extract helpers (MethodLength)
- Replace case-when with CONTENT_TYPE_MAP hash lookup
- Rename short param `sc` to `server_config`
- Convert Class.new error constants to class keyword syntax
- Restore two-pass loop in load_async_api_resources (publish before
  subscribe ordering is intentional)
- Exclude node_modules from rubocop, add gemspec/rails_app cop configs
- Mark pending test for queue-bound message forwarding

553 specs passing, 0 rubocop offenses.
- Bump version 0.6.0 -> 0.7.0
- Fix @param tag for anonymous forwarding in FaradayConnectionProxy
- Reorder .yardopts flags for clarity
- Fix RELEASING.md formatting and branch name references
@ipublic ipublic added the enhancement New feature or request label May 1, 2026
ipublic added 3 commits May 1, 2026 14:01
- Pass middleware options as keyword args (**value[:options]) in
  FaradayConnectionProxy#build_connection — Faraday 2.x Response::Json
  takes 0..1 positional args, not a hash
- Resolve actions on each message in Worker#spawn_threads instead of
  caching at spawn time — subscribers register after the worker starts,
  so cached actions are empty
…flow

The handler's rescue clause matches on exception class, not origin.
Raising directly is equivalent and avoids the multi-second delay from
unwinding thousands of stack frames.
Scope RabbitMQ connection setup to only the contexts that need live
connections, avoiding ~45s of unnecessary connection starts for stubbed
tests. Upgrade GitHub Actions to Node.js 24-compatible versions.

- Move before { connection.start } into live-test contexts in
  bunny_channel_proxy_spec, bunny_queue_proxy_spec (58.8s -> 4.1s)
- Reduce cancel_consumers_for drain timeouts to 0.2s/0.5s
- Stub executable_for on subscriber doubles to prevent thread errors
- Remove redundant pending test placeholder in publish_operation_spec
- Upgrade actions/checkout v2 -> v4, actions/cache v4 -> v5
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the EventSource gem to Ruby 3.4.9 / Ruby >= 3.2, updates the HTTP (Faraday 2.x) and AMQP (Bunny/RabbitMQ) protocol layers for safer runtime behavior, and brings the repo to green lint/docs with expanded test coverage.

Changes:

  • Upgrade Ruby + gem dependencies (Faraday 2.x, dry-*), update CI matrix, bump version to 0.7.0.
  • Harden AMQP consumer execution/connection handling and modernize HTTP Faraday request/queue/connection proxies.
  • Expand/refactor specs (including new RabbitMQ integration coverage) and documentation/config cleanup.

Reviewed changes

Copilot reviewed 140 out of 143 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
spec/support/session_concern.rb Adds shared session helper module for specs.
spec/support/config/logging.rb Minor formatting tweak in spec logging setup.
spec/support/apis/fake_github.rb Expands Fake GitHub API endpoints + request body parsing.
spec/spec_helper.rb Changes support file loading behavior.
spec/shared_contexts/amqp/channel_item.rb Minor formatting (blank line) change.
spec/rails_app/spec/sms_messages_publisher_spec.rb Fixes require_relative path.
spec/rails_app/spec/sms_blocklist_updater_spec.rb Fixes require path and removes rubocop comments around global var usage.
spec/rails_app/spec/railtie_spec.rb Adjusts subscriber double to include name.
spec/rails_app/spec/rails_helper.rb Adds frozen string literal header.
spec/rails_app/spec/mitc_response_subscriber_spec.rb Normalizes requires and constant references.
spec/rails_app/spec/http_service_integration_spec.rb Normalizes requires and regex literal style.
spec/rails_app/spec/determination_subscriber_spec.rb Normalizes require path.
spec/rails_app/spec/determination_publisher_spec.rb Normalizes require path.
spec/rails_app/config/initializers/event_source.rb Simplifies Dir / File usage + schema list build.
spec/rails_app/config/environments/production.rb Removes leading :: from Logger constant usage.
spec/rails_app/app/event_source/subscribers/sms_blocklist_subscriber.rb Removes rubocop disable/enable around global var.
spec/rails_app/app/event_source/subscribers/mitc_response_subscriber.rb Prefixes unused block args with _.
spec/rails_app/app/event_source/subscribers/event_log_subscriber.rb Removes unused rescue variable.
spec/rails_app/app/event_source/subscribers/enterprise_subscriber.rb Removes unused rescue variables.
spec/rails_app/app/event_source/publishers/sms_messages_publisher.rb Minor formatting.
spec/rails_app/app/event_source/publishers/sms_blocklist_publisher.rb Minor formatting.
spec/rails_app/app/event_source/publishers/mitc_publisher.rb Minor formatting.
spec/event_source/worker_spec.rb Major spec rewrite: adds start/stop/dispatch/error-resilience assertions.
spec/event_source/worker_pool_spec.rb Adds unit coverage for WorkerPool singleton/thread pool behavior.
spec/event_source/uris/amqp_uri_spec.rb Removes leading :: in URI expectation.
spec/event_source/subscriber_spec.rb Formats long regex expectation across lines.
spec/event_source/queue_spec.rb Adds coverage for Queue behavior and action registration.
spec/event_source/publisher_spec.rb Minor block formatting update.
spec/event_source/publish_operation_spec.rb Switches requires + formatting cleanups.
spec/event_source/protocols/http/soap/operations/generate_username_token_components_spec.rb Removes leading :: from constants.
spec/event_source/protocols/http/soap/operations/encode_soap_payload_spec.rb Removes leading :: from constants.
spec/event_source/protocols/http/soap/operations/decorate_payload_using_configuration_spec.rb Removes leading :: from constants.
spec/event_source/protocols/http/faraday_request_proxy_spec.rb Expands request proxy coverage (methods, payloads, headers, error statuses).
spec/event_source/protocols/http/faraday_queue_proxy_spec.rb Expands queue proxy coverage + ChannelItem usage.
spec/event_source/protocols/http/faraday_connection_proxy_spec.rb Adds/expands unit coverage for connection proxy behavior.
spec/event_source/protocols/http/faraday_channel_proxy_spec.rb Adds coverage for channel proxy operations and publish flows.
spec/event_source/protocols/amqp/types_spec.rb Adds coverage for AMQP Dry::Types enum behavior.
spec/event_source/protocols/amqp/error_spec.rb Adds coverage for AMQP error wrapper/original exception behavior.
spec/event_source/protocols/amqp/contracts/subscribe_operation_binding_contract_spec.rb Adds contract validation edge-case coverage.
spec/event_source/protocols/amqp/contracts/publish_operation_binding_constract_spec.rb Adds contract validation edge-case coverage.
spec/event_source/protocols/amqp/contracts/channel_binding_contract_spec.rb Adds invalid-parameter and minimal-valid coverage.
spec/event_source/protocols/amqp/bunny_message_proxy_spec.rb Adds delegation coverage for BunnyMessageProxy.
spec/event_source/protocols/amqp/bunny_exchange_proxy_spec.rb Formatting alignment in publish binding expectations.
spec/event_source/protocols/amqp/bunny_consumer_proxy_spec.rb Adds unit coverage for consumer cancellation flag behavior.
spec/event_source/protocols/amqp/bunny_consumer_handler_spec.rb Normalizes shared context requires + loop style.
spec/event_source/protocols/amqp/bunny_consumer_handler_integration_spec.rb Adds live RabbitMQ integration specs for handler exception behavior and signal propagation.
spec/event_source/protocols/amqp/bunny_connection_proxy_spec.rb Adds extensive stubbed unit coverage and URL parsing tests.
spec/event_source/protocols/amqp/bunny_channel_proxy_spec.rb Adds extensive stubbed channel proxy coverage; scopes live connection setup to context.
spec/event_source/operations/fetch_session_spec.rb Removes inline SessionConcern in favor of shared support module.
spec/event_source/operations/build_message_spec.rb Removes inline SessionConcern in favor of shared support module.
spec/event_source/operations/build_message_options_spec.rb Removes inline SessionConcern in favor of shared support module.
spec/event_source/message_spec.rb Removes inline SessionConcern in favor of shared support module.
spec/event_source/example_services/ridp_service_spec.rb Updates stubbed Faraday User-Agent to match runtime Faraday::VERSION.
spec/event_source/event_spec.rb Cleans up dead commented tests and adds coverage for missing publisher_path + attribute setter behavior.
spec/event_source/connection_manager_spec.rb Fixes subscriber double stubs + reduces cancel_consumer timeouts.
spec/event_source/command_spec.rb Removes unused assignment.
spec/event_source/channel_spec.rb Fixes subscriber double stubs for executable_for.
spec/event_source/async_api/operations/servers/create_spec.rb Uses except(:url) to compare hashes.
spec/event_source/async_api/operations/channels/open_spec.rb Replaces placeholder pending example with explicit “not implemented” expectation.
spec/event_source/async_api/contracts/server_contract_spec.rb Fixes variables array literal structure.
spec/event_source/async_api/contracts/security_scheme_contract_spec.rb Updates expected error string formatting.
spec/event_source/async_api/contracts/message_contract_spec.rb Converts $ref keys to quoted-symbol form.
spec/event_source/async_api/contracts/channels_contract_spec.rb Converts $ref keys to quoted-symbol form.
spec/event_source/async_api/contracts/async_api_conf_contract_spec.rb Converts $ref keys to quoted-symbol form.
lib/event_source/worker_pool.rb Adds documented, constantized global thread pool implementation.
lib/event_source/worker.rb Reworks worker lifecycle/shutdown semantics + adds dispatch error resilience.
lib/event_source/version.rb Bumps gem version to 0.7.0.
lib/event_source/types.rb Adds module-level doc comment.
lib/event_source/subscriber.rb Minor refactor + adds comment.
lib/event_source/railtie.rb Narrows shutdown rescue to StandardError and simplifies control flow.
lib/event_source/queue.rb Expands docs + adds empty?/size and clarifies behavior.
lib/event_source/publisher.rb Simplifies publisher initialization loop.
lib/event_source/protocols/http_protocol.rb Updates Faraday requires for Faraday 2.x retry middleware.
lib/event_source/protocols/http/subscribe_bindings.rb Adds class doc comment.
lib/event_source/protocols/http/publish_bindings.rb Adds class doc comment.
lib/event_source/protocols/http/faraday_request_proxy.rb Updates request execution for Faraday 2.x (run_request) and refactors payload/header handling.
lib/event_source/protocols/http/faraday_queue_proxy.rb Refactors subscription key building and delegation.
lib/event_source/protocols/http/faraday_connection_proxy.rb Updates middleware calls to use keyword splat; refactors content type mapping.
lib/event_source/protocols/http/faraday_channel_proxy.rb Uses warn instead of non-existent warning; delegation refactor.
lib/event_source/protocols/http/error.rb Converts error constants to explicit classes.
lib/event_source/protocols/http/contracts/subscribe_operation_bindings_contract.rb Refactors extension-key coercion logic (but see review comments).
lib/event_source/protocols/http/contracts/publish_operation_bindings_contract.rb Refactors extension-key coercion logic (but see review comments).
lib/event_source/protocols/arn/sns_publisher_proxy.rb Extracts SNS SMS publish logic into helpers.
lib/event_source/protocols/arn/contracts/sns_publish_operation_binding_contract.rb Simplifies contract rule flow.
lib/event_source/protocols/arn/contracts/sns_channel_bindings_contract.rb Fixes quoted symbol for x-aws-sdk key.
lib/event_source/protocols/amqp/types.rb Adds more detailed module docs.
lib/event_source/protocols/amqp/subscribe_bindings.rb Adds struct docs.
lib/event_source/protocols/amqp/publish_bindings.rb Adds struct docs.
lib/event_source/protocols/amqp/error.rb Fixes initializer name + expands docs; converts error constants to classes.
lib/event_source/protocols/amqp/contracts/contract.rb Adds base contract docs.
lib/event_source/protocols/amqp/contracts/channel_binding_contract.rb Expands contract docs.
lib/event_source/protocols/amqp/channel_binding.rb Fixes typo attribureattribute.
lib/event_source/protocols/amqp/bunny_queue_proxy.rb Refactors message receipt logging/decoding/dispatch, adds respond_to_missing?, improves docs.
lib/event_source/protocols/amqp/bunny_message_proxy.rb Implements respond_to_missing? + delegation cleanup.
lib/event_source/protocols/amqp/bunny_exchange_proxy.rb Improves docs + fixes duplicated slice key.
lib/event_source/protocols/amqp/bunny_consumer_proxy.rb Documents and clarifies consumer cancellation flag behavior.
lib/event_source/protocols/amqp/bunny_consumer_handler.rb Replaces rescue Exception with targeted rescue list and improves logging.
lib/event_source/protocols/amqp/bunny_connection_proxy.rb Fixes protocol_version default and adds docs/introspection delegation fixes.
lib/event_source/protocols/amqp/bunny_channel_proxy.rb Adds docs + adds respond_to_missing?/delegation cleanup.
lib/event_source/protocols.rb Adds extensive architecture / usage documentation.
lib/event_source/operations/mime_encode.rb Adjusts Dry::Monads include style for YARD; minor doc fix.
lib/event_source/operations/mime_decode.rb Adjusts Dry::Monads include style; refactors validation condition.
lib/event_source/operations/fetch_session.rb Adjusts Dry::Monads include style; removes unused local.
lib/event_source/operations/create_message.rb Adjusts Dry::Monads include style.
lib/event_source/operations/build_message_options.rb Adjusts Dry::Monads include style.
lib/event_source/operations/build_message.rb Adjusts Dry::Monads include style.
lib/event_source/helpers.rb Adds deep_merge compatibility helper.
lib/event_source/event.rb Refactors publisher_path guard + formatting cleanups.
lib/event_source/error.rb Converts error constants to explicit classes.
lib/event_source/content_type_resolver.rb Adds class doc comment.
lib/event_source/connection_manager.rb Simplifies loops and improves cancel_consumers logic.
lib/event_source/configure/servers.rb Switches deep_merge require to event_source/helpers.
lib/event_source/configure/server_configurations/http_configuration.rb Removes unnecessary parentheses on super.
lib/event_source/configure/server_configurations/arn_configuration.rb Removes unnecessary parentheses on super.
lib/event_source/configure/operations/validate_server_configurations.rb Improves variable naming in validation loops.
lib/event_source/configure/config.rb Switches deep_merge require, adjusts schema processing order, removes .sort on requires.
lib/event_source/boot_registry.rb Removes unused set require.
lib/event_source/async_api/types.rb Regex cleanup for email type.
lib/event_source/async_api/subscribe_operation.rb Adds class doc comment.
lib/event_source/async_api/subscribe_bindings.rb Adds class doc comment.
lib/event_source/async_api/publish_operation.rb Adds class doc comment.
lib/event_source/async_api/operations/servers.rb Adds module doc comment.
lib/event_source/async_api/operations/channels.rb Adds module doc comment.
lib/event_source/async_api/operations/channel_items.rb Adds module doc comment.
lib/event_source/async_api/operations/async_api_conf/load_path.rb Adjusts Dry::Monads include style for YARD.
lib/event_source/async_api/operations/async_api_conf.rb Adds module doc comment.
lib/event_source/async_api/operations.rb Adds module doc comment.
lib/event_source/async_api/info.rb Adds class doc comment.
lib/event_source/async_api/exchange.rb Adds class doc comment.
lib/event_source/async_api/error.rb Converts error constants to explicit classes.
lib/event_source/async_api/contracts/variable_contract.rb Adds contract doc comment.
lib/event_source/async_api/contracts.rb Adds module doc comment.
lib/event_source.rb Updates dry-types require; requires event_source/helpers.
event_source.gemspec Raises required Ruby version, updates dependencies for Faraday 2.x, adds MFA metadata.
docker-compose.yml Adds RabbitMQ service for local integration testing.
RELEASING.md Updates release docs and formatting.
README.md Major rewrite: requirements, config, usage, architecture, development workflow.
.yardopts Updates YARD configuration and excludes.
.ruby-version Updates Ruby version to 3.4.9.
.rubocop.yml Updates TargetRubyVersion and exclusions.
.github/workflows/rspec.yml Updates GitHub Actions versions and Ruby matrix.
Comments suppressed due to low confidence (1)

.github/workflows/rspec.yml:15

  • The gem cache key for the rubocop job is hard-coded to 3.2.1, but the workflow now runs against newer Rubies (and may default to .ruby-version). This can cause cache collisions/stale dependencies across Ruby versions. Include the actual Ruby version in the key (or use steps.setup-ruby.outputs.ruby-version).
      - name: Cache Gems
        uses: actions/cache@v5
        with:
          path: vendor/bundle
          key: ${{ runner.os }}-3.2.1-event_source-gems-${{ hashFiles('**/event_source.gemspec') }}-${{ hashFiles('**/Gemfile' ) }}
      - name: bundle install

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread spec/event_source/protocols/amqp/bunny_consumer_handler_spec.rb
Comment thread spec/spec_helper.rb
Comment thread spec/rails_app/spec/sms_messages_publisher_spec.rb

module EventSource
VERSION = "0.6.0"
VERSION = "0.7.0"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump Version to "1.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants