Adopt the released reader: all four levels forward - #13
Merged
Conversation
The library pin moves to idfkit==1.0.0-rc.4 and the docs level to docs-2026.4, both published today. The governance level moves two behind to governance-2026.17, which is not this feature's doing but is this feature's to carry forward, and the conformance level from 2026.8 to 2026.12. The vendored TypeScript tree gains the three examples the weather pages reference and could not resolve: the two for the reader and the climate zone filter, which is authored in idfkit-js because docs/snippets/js/ is vendored and sync_js_artifacts --check rejects a file present only in the vendored copy.
Contributor
|
Docs preview for this PR is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both libraries released today, so the four pinned levels can move. This is what turns #10 and #11 from red to green, and it is the only thing that was ever holding them.
[tool.idfkit.library]+ the==dependency pin[tool.idfkit.conformance][tool.idfkit.governance][tool.idfkit.docs]The governance level was two behind before this feature touched it. Not this feature's doing, but this feature's to carry forward.
The vendored TypeScript tree gains the three examples the weather pages reference and could not resolve: the two for the reader, and
filter_by_climate_zone.ts. All three are authored in idfkit-js rather than here, becausedocs/snippets/js/is vendored andsync_js_artifacts.py --checkrejects a file present only in the vendored copy.docs-2026.4was cut from idfkit-js to carry them.Verified against the stack, not just alone
This branch is green on its own —
make checkexits 0, strict build has no errors. But on its own it does not exercise the pages that needed it, which live on #10 and #11. So I merged all three locally and built that:LOCAL OVERRIDEwarning is gone:parity("weather-file-reading")now resolves from the real pinned tag rather than a working treeweather/reading.mdrenders with both language tabsmake checkexits 0: page kinds, capability declarations, engine assets, and✅ The vendored examples and TypeDoc reference match docs-2026.4The remaining strict-mode warnings are 109
cairosvgcrashes, which is the social plugin wanting libcairo on my machine and is identical with and without this change.Merge order
This one first. Then #10 and #11 rebase onto main and go green without further edits.