Changed login button to register interest - #46
Merged
Conversation
Contributor
Author
|
anniexwang
reviewed
Jul 10, 2026
| {% else %} | ||
| <li> | ||
| <a href="{{ url("event:login") }}" class="btn-small waves-effect waves-light colorBtn">Login</a> | ||
| <a href="{% if request.path == url('event:index') %}#interest{% else %}{{ url('event:index') }}#interest{% endif %}" class="btn-small waves-effect waves-light colorBtn">Register Your Interest</a> |
There was a problem hiding this comment.
is there a reason for having a conditional link? can this be simplified?
anniexwang
requested changes
Jul 12, 2026
| {% endif %} | ||
| {% endblock %} | ||
|
|
||
| {% block nav_logout_login_links %} |
There was a problem hiding this comment.
why was this chunk of code added in the fix instead of just adding
{% else %} <li> <a href="#interest" class="btn-small waves-effect waves-light colorBtn">Register Your Interest</a> </li> {% endif %}
to base.html?
Contributor
Author
There was a problem hiding this comment.
yeah, sorry that's a much better approach
anniexwang
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview