Repository navigation
Conversation
A user wrapper's constructor or destructor can unregister the wrapper while unlink(), rename(), mkdir(), rmdir(), touch(), chmod() or stat() is using it, which frees the wrapper, and the "is not implemented!" warning then reads the freed wrapper and its class. Hold a reference to the wrapper resource for the whole operation, as user_wrapper_opener() and user_wrapper_opendir() already do.
Owner
Author
|
Promoted upstream: php#24754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user stream wrapper whose constructor or destructor calls stream_wrapper_unregister() frees the wrapper while unlink(), rename(), mkdir(), rmdir(), touch(), chmod() or stat() is still using it, and when the method is not implemented the "is not implemented!" warning reads the freed wrapper and its class name. user_wrapper_opener() and user_wrapper_opendir() already hold a reference to the wrapper resource across the user calls; the URL operations now do the same.
This reproduces on PHP-8.4 through master under valgrind; it targets master because it needs a wrapper that unregisters itself. Found while reviewing php#24711, which fixes the separate opendir() error-report regression on PHP-8.6.