feat(build): bump to Java 25 and verify Spigot 1.21–26.2 compatibility - #175
Merged
Conversation
Raise the toolchain and bytecode target to Java 25, and apply the compiler
options to every JavaCompile task instead of only compileJava, so test
compilation no longer targets a different release than production code.
The plugin is built against the newest Spigot API while advertising
api-version 1.21, which had silently drifted out of compatibility:
* Sound#getKeyOrThrow() and Enchantment#getKeyOrThrow() come from
org.bukkit.registry.RegistryAware, a type that does not exist on 1.21.
* Falling back to getKey() alone is not enough either — org.bukkit.Sound
was an enum back then and is an interface today, so compiling against
the new API emits invokeinterface and 1.21 throws
IncompatibleClassChangeError.
Read the key through org.bukkit.Keyed, an interface in every supported
version, so the emitted call site resolves on both ends of the range.
Two verification tasks now run as part of check, in every module:
* compileJavaSpigotMin recompiles the sources against the oldest
supported API and catches newer-only symbols.
* checkSpigotBinaryCompatibility scans the emitted org/bukkit call sites
with ASM and reports unresolved members as well as invokeinterface /
invokevirtual mismatches, which the source compile cannot see.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the toolchain and bytecode target to Java 25, and apply the compiler options to every JavaCompile task instead of only compileJava, so test compilation no longer targets a different release than production code.
The plugin is built against the newest Spigot API while advertising api-version 1.21, which had silently drifted out of compatibility:
Read the key through org.bukkit.Keyed, an interface in every supported version, so the emitted call site resolves on both ends of the range.
Two verification tasks now run as part of check, in every module: