Skip to content

🐛 Review: read a zipped store's label groups in place - #46

Open
lguerard wants to merge 2 commits into
mainfrom
claude/admiring-knuth-oyf3kd
Open

lguerard wants to merge 2 commits into
mainfrom
claude/admiring-knuth-oyf3kd

Conversation

@lguerard

Copy link
Copy Markdown
Contributor

Problem

Review(<bundle>.zarr.zip) failed with FileNotFoundError. Review._load_decisions and nearest_parents opened label groups with a plain zarr.open_group, which cannot follow bundle.zip/labels/<name>.

napari-chunked-regionprops builds its corrected object table through Review(store).effective(name). On a bundle it therefore logged a traceback and fell back to the raw table: no review decisions applied, and no shape or position columns.

Fix

Both read-only call sites now use open_group_any, like the rest of the read path. Writing review decisions into a bundle is still refused with PermissionError, as before.

Tests

  • New test_a_zip_bundle_is_reviewed_read_only: a zipped scene gives the same corrected tables as the directory, keeps its saved decisions, and refuses new ones. It fails without the fix and passes with it.
  • test_review.py, test_tables.py and test_napari.py pass after merging the latest main.
  • No new ruff findings in the changed files.
  • The full suite has the same failures with and without this change; they come from optional packages missing in the test container.

Goes with imcf/napari-chunked-regionprops#1, the fix for "No patchworks object table next to these labels" on zipped stores. Once both are released, the floors in pyproject.toml (napari-chunked-regionprops>=…) and workflow/viewer/pixi.toml (patchworks>=…) should be raised so pixi install picks them up.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PfZ9brRCJ2iCMswgjuSC1x


Generated by Claude Code

claude added 2 commits October 8, 2026 11:37
Review._load_decisions and nearest_parents opened groups with a plain
zarr.open_group, which cannot follow bundle.zip/labels/<name>. So the
corrected view of a .zip bundle failed, and napari-chunked-regionprops
fell back to the raw table. Use open_group_any, like the rest of the
read path.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PfZ9brRCJ2iCMswgjuSC1x

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants