Repository navigation
Conversation
Review._load_decisions and nearest_parents opened groups with a plain zarr.open_group, which cannot follow bundle.zip/labels/<name>. So the corrected view of a .zip bundle failed, and napari-chunked-regionprops fell back to the raw table. Use open_group_any, like the rest of the read path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PfZ9brRCJ2iCMswgjuSC1x
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Review(<bundle>.zarr.zip)failed withFileNotFoundError.Review._load_decisionsandnearest_parentsopened label groups with a plainzarr.open_group, which cannot followbundle.zip/labels/<name>.napari-chunked-regionprops builds its corrected object table through
Review(store).effective(name). On a bundle it therefore logged a traceback and fell back to the raw table: no review decisions applied, and no shape or position columns.Fix
Both read-only call sites now use
open_group_any, like the rest of the read path. Writing review decisions into a bundle is still refused withPermissionError, as before.Tests
test_a_zip_bundle_is_reviewed_read_only: a zipped scene gives the same corrected tables as the directory, keeps its saved decisions, and refuses new ones. It fails without the fix and passes with it.test_review.py,test_tables.pyandtest_napari.pypass after merging the latestmain.Goes with imcf/napari-chunked-regionprops#1, the fix for "No patchworks object table next to these labels" on zipped stores. Once both are released, the floors in
pyproject.toml(napari-chunked-regionprops>=…) andworkflow/viewer/pixi.toml(patchworks>=…) should be raised sopixi installpicks them up.🤖 Generated with Claude Code
https://claude.ai/code/session_01PfZ9brRCJ2iCMswgjuSC1x
Generated by Claude Code