Fix #130: Incorrect validation of initial_options for OptionGroup#131
Open
nickovs wants to merge 1 commit intoimryche:masterfrom
Open
Fix #130: Incorrect validation of initial_options for OptionGroup#131nickovs wants to merge 1 commit intoimryche:masterfrom
nickovs wants to merge 1 commit intoimryche:masterfrom
Conversation
…oup entries. The `initial_option` [field](https://docs.slack.dev/reference/block-kit/block-elements/select-menu-element#fields) of a `StaticSelect` should single option even when the menu contains `OptionGroup`s. This PR fixes the validator and fixes the broken tests that let the old validator pass. The fix also applies to the validation of `MultiStaticSelect` and the tests of that are fixes as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
initial_optionfield of aStaticSelectshould be single option even when the menu containsOptionGroups. This PR fixes the validator and fixes the broken tests that let the old validator pass.The fix also applies to the validation of
MultiStaticSelectand the tests of that are fixes as well.