feat: DISMISS F# protocol (v1.2.0)#4
Conversation
When the reviewer flags findings the agent disagrees with, the agent can reply 'DISMISS F1: reason'. After 2 dismissals of the same finding, it's suppressed in future review cycles within that session. - Findings are numbered (F1, F2, ...) in review messages - Agent told to use DISMISS F#: reason format - DismissTracker in orchestrator stores dismissed findings - filterSuppressed removes them before display - If all findings suppressed, review auto-passes as LGTM - 14 new unit tests for dismiss module - All 413 tests green
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c81c77ec5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const filteredResult = orchestrator.applyDismissFiltering(outcome.senior.result); | ||
|
|
||
| // If dismiss filtering converted issues to LGTM, clear the issues state | ||
| if (filteredResult.isLgtm && !outcome.senior.result.isLgtm) { | ||
| orchestrator.clearIssuesAfterDismiss(); |
There was a problem hiding this comment.
When applyDismissFiltering flips a senior result from ISSUES_FOUND to LGTM, this path sends an LGTM message but outcome.architect is still absent because architect execution already happened (or was skipped) inside handleAgentEnd based on the unfiltered result. For multi-file git-based changes, that bypasses the intended architect cross-file check and can tell the agent it's safe to push without ever running it. This occurs whenever all remaining findings are suppressed via DISMISS F#.
Useful? React with 👍 / 👎.
1 participant
Fixes the max-repeat review loop. Agent can now dismiss false positives.
How it works:
- **F1 Medium:** file:line — problemDISMISS F1: intentional design14 new tests, all 413 green.