Update docker-compose.yml#1
Open
tmmjelde wants to merge 1 commit into
Open
Conversation
While hard coding the ports on the host side does work better for people if they do not use the .env file, it will potentially cause some problems for those who do run a cluster of servers and decide to change the ports in the .env file. This change would link the docker-compose.yml file to the .env file, but would also provide default values in case someone decides not to use the .env file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change would allow the docker-compose.yml file to attempt to use the variables in .env file.
If those variables are undefined (missing .env file) it will use the default values instead.
This should make it easier to set up a cluster of servers on the same host without having to modify the ports multiple places.