Tweak precompute to avoid apply_single_writer_dependency_heuristic warning#1008
Open
majosm wants to merge 1 commit into
Open
Tweak precompute to avoid apply_single_writer_dependency_heuristic warning#1008majosm wants to merge 1 commit into
precompute to avoid apply_single_writer_dependency_heuristic warning#1008majosm wants to merge 1 commit into
Conversation
…f the temporary's users avoids warning in apply_single_writer_dependency_heuristic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the precomputed temporary as a dependency of its readers on top of the existing dependency on the created global barrier.
apply_single_writer_dependency_heuristicdoesn't detect the transitive dependencyreader -> barrier -> temp, so without this it emits a warning.