Skip to content

fix: update vSphere plugin documentation and configuration examples#7159

Merged
NguyenHoangSon96 merged 4 commits into
masterfrom
invalid_config_vsphere3
Apr 29, 2026
Merged

fix: update vSphere plugin documentation and configuration examples#7159
NguyenHoangSon96 merged 4 commits into
masterfrom
invalid_config_vsphere3

Conversation

@NguyenHoangSon96
Copy link
Copy Markdown
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Mar 31, 2026

Closes 26912

  • My steps to fix:
  1. Check out the source telegraf to my local.
  2. Run go run ./cmd/telegraf config > etc/telegraf.conf command to generate etc/telegraf.conf file.
  3. Tweak the src/writeData/utils/updateTelegrafPlugins.mjs so it will get contents from my local influxdata/telegra/etc/telegraf.conf instead of the remote repository /influxdata/telegraf.
  4. Run telegraf-plugins:update command to generate new contents for md and conf files.
  5. Create this PR.

This is just a very primitive implementation of the updateTelegrafPlugins.mjs to make the script work
updateTelegrafPlugins.txt

  • Some thoughts:
  1. I don't know how these things should work exactly; this is just my assumption. If my fixes are not correct, then I will just manually remove the - at the beginning of the .conf file.
  2. If this is correct, then we should update the src/writeData/utils/README.md guidance and the src/writeData/utils/updateTelegrafPlugins.mjs script file to get contents from etc/telegraf.conf in the local repository, not the remote.
  • Before the fix, there is a - at the beginning of the file.
Screen.Recording.2025-10-22.at.09.55.53.mov
  • After I modify src/writeData/utils/updateTelegrafPlugins.mjs and run the command telegraf-plugins:update, the - at the beginning of the file disappears.
Screen.Recording.2025-10-22.at.10.01.23.mov

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 31, 2026
@NguyenHoangSon96 NguyenHoangSon96 requested review from a team as code owners March 31, 2026 06:46
@NguyenHoangSon96 NguyenHoangSon96 changed the title Invalid config vsphere3 fix: update vSphere plugin documentation and configuration examples Mar 31, 2026
@bednar bednar requested a review from wdoconnell April 9, 2026 08:17
@bednar
Copy link
Copy Markdown
Contributor

bednar commented Apr 9, 2026

Hi @wdoconnell, can you take a look to this PR? It is new version of the #7091 with all requirements.

@srebhan
Copy link
Copy Markdown
Member

srebhan commented Apr 29, 2026

The code looks good from Telegraf's point-of-view.

Copy link
Copy Markdown
Contributor

@eatondustin1 eatondustin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given that Bill already approved this previously.

@NguyenHoangSon96 NguyenHoangSon96 added this pull request to the merge queue Apr 29, 2026
Merged via the queue into master with commit 76703d9 Apr 29, 2026
7 of 8 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the invalid_config_vsphere3 branch April 29, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.x] Influx generating invalid/broken config for vCenter

4 participants