[pull] main from firecrawl:main - #436
Merged
Merged
Conversation
…hon, Go, and Rust SDKs (#4625) * feat(sdks): Alexandria discovery and execution in the JavaScript, Python, Go, and Rust SDKs Search with the alexandria source and domainTools returns tool contracts in data.tools; scrape with an alexandria body executes one capability or up to ten with a request id and returns data.alexandria with data.creditsCost; Find Tools walks the catalogue for free. Tool contract fields the API omits are optional, and a 403 THIRD_PARTY_DATA_TERMS_REQUIRED surfaces requiresAction on each SDK's error type. Verified live against api.firecrawl.dev. * fix(rust-sdk): box requires_action to keep FirecrawlError small; drop an unused test fixture * fix(rust-sdk): box the API error details so FirecrawlError stays under clippy's size limit * chore(js-sdk): drop a stray npm lockfile; the package is managed with pnpm * fix(sdks): address Alexandria review findings Preserve Go catalogue error status, expose Rust contract fields, classify Python terms errors by code, validate integer timeouts, and allow the capped API deadline plus 30 seconds in JS and Python. Correct README examples and strengthen contract, boundary, timeout, and test isolation coverage. Review triage: Document forward references resolve successfully (regression covered); reqwest has no default request timeout; existing search parsing does not silently discard malformed records, so retain strict tool contract validation. Validation: Python v2 465 passed; JS targeted suites 20 passed and SDK build passed; Rust tools integration passed; Go full suite passed with race detection. * Update apps/go-sdk/tools_test.go Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )