Skip to content

Update AGENT.md to understand teal.picks - #1730

Merged
averissimo merged 17 commits into
mainfrom
skills-update
Sep 7, 2026
Merged

Update AGENT.md to understand teal.picks#1730
averissimo merged 17 commits into
mainfrom
skills-update

Conversation

@averissimo

@averissimo averissimo commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Pull Request

This PR follows best practices that we found when converting module packages to teal.picks to create a simple example module that uses this functionality.

Changes description

  • Add teal.picks to packages
  • Update example module to a working module that:
    • Uses encoding selectors
      • teal.picks to select variables
    • Generates outputs inside qenv
    • Uses both ggplot2 and gtsummary

Comment thread AGENTS.md
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/after.R                            59      21  64.41%   42-52, 64, 69, 77-79, 81-89, 100, 104-105
R/checkmate.R                        24       0  100.00%
R/decorators-helpers.R               59       1  98.31%   113
R/dummy_functions.R                  61       2  96.72%   54, 56
R/include_css_js.R                   11       0  100.00%
R/init.R                            136       0  100.00%
R/module_bookmark_manager.R          99      54  45.45%   78-133
R/module_data_summary.R             177       8  95.48%   40, 50, 205, 236-240
R/module_filter_data.R               64       0  100.00%
R/module_filter_manager.R           210       7  96.67%   119-120, 316, 343, 355, 362-363
R/module_nested_tabs.R              411      42  89.78%   120, 178-183, 211, 315-330, 350-354, 409, 527-530, 534-537, 541-544
R/module_session_info.R              18       0  100.00%
R/module_snapshot_manager.R         276       9  96.74%   315-319, 386, 389-391
R/module_source_code.R               69       0  100.00%
R/module_teal_lockfile.R            131      53  59.54%   45-57, 60-62, 76, 86-88, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186
R/module_teal_reporter.R            122       9  92.62%   60, 77-78, 81, 98, 128, 142, 144, 158
R/module_teal.R                     309      26  91.59%   136, 185, 241, 271-291, 321-322
R/module_transform_data.R           164      25  84.76%   77-81, 85-89, 106, 112, 119-120, 134-138, 188, 273-277
R/module_validate_error.R            73       0  100.00%
R/modules.R                         345      50  85.51%   170-174, 229-232, 332, 339, 353, 472, 570-576, 706-712, 725-733, 748-763, 796, 808-816
R/reporter_previewer_module.R        41      12  70.73%   41, 45, 68-85
R/teal_data_module-eval_code.R       23       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 23       0  100.00%
R/teal_data_utils.R                  49       0  100.00%
R/teal_modifiers.R                   57       0  100.00%
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      48       2  95.83%   153-154
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   363     255  29.75%   68-73, 125, 133-162, 193-202, 212, 227-275, 300-575, 603-628, 683, 685-688, 707-721, 738-739, 750-767
R/utils.R                           290      48  83.45%   404-453, 541-550
R/validate_inputs.R                  57       0  100.00%
R/validations.R                      58       0  100.00%
R/zzz.R                              23       1  95.65%   25
TOTAL                              3931     625  84.10%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 3bc6496

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   32 suites   3m 12s ⏱️
469 tests 419 ✅ 50 💤 0 ❌
744 runs  690 ✅ 54 💤 0 ❌

Results for commit 3bc6496.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $122.82$ $+11.40$ $0$ $0$ $0$ $0$
shinytest2-validate_input 💔 $26.47$ $+1.53$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_teal 💔 $0.69$ $+1.03$ teal_src_Show_R_code_button_reason_is_null_when_there_is_working_code

Results for commit 4b45bd2

♻️ This comment has been updated with latest results.

@osenan osenan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good improvement.
I have minor comments on the usage of teal::need_input or validate_input, but it is not much different.
The new example is much better

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md
Comment thread AGENTS.md
Comment thread AGENTS.md

@llrs-roche llrs-roche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time reading the document. I left some comments but most of them are not focused on teal.picks, where it does a great job, but rather on how the file will steer the AI.

General comments:

  • there is no mention of decorators and transformers on the examples provided
  • There is no mention on shinytests2 if testServer() can't cover up to 80%

I am not sure all these are specific to the repository or they are more general for the whole teal framework. However, in general I agree with your answers to the previous comments and I think it can be merged.

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
averissimo and others added 7 commits August 25, 2026 14:21
Co-authored-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com>
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
@averissimo

Copy link
Copy Markdown
Contributor Author

@llrs-roche added transformators and decorators. The example didn't grow too much and it becomes much more complete.

Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com>
@averissimo
averissimo merged commit 8abd9fd into main Sep 7, 2026
29 checks passed
@averissimo
averissimo deleted the skills-update branch September 7, 2026 13:17
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants