Skip to content

export select_decorators() - #1734

Merged
wangben718 merged 7 commits into
mainfrom
1733-feature-request-export-select_decorators
Aug 31, 2026
Merged

export select_decorators()#1734
wangben718 merged 7 commits into
mainfrom
1733-feature-request-export-select_decorators

Conversation

@wangben718

Copy link
Copy Markdown
Contributor

Pull Request

Fixes #1733

@wangben718 wangben718 linked an issue Aug 27, 2026 that may be closed by this pull request
3 tasks
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@wangben718

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/after.R                            59      21  64.41%   42-52, 64, 69, 77-79, 81-89, 100, 104-105
R/checkmate.R                        24       0  100.00%
R/decorators-helpers.R               59       1  98.31%   113
R/dummy_functions.R                  61       2  96.72%   54, 56
R/include_css_js.R                   11       0  100.00%
R/init.R                            136       0  100.00%
R/module_bookmark_manager.R          99      54  45.45%   78-133
R/module_data_summary.R             177       8  95.48%   40, 50, 205, 236-240
R/module_filter_data.R               64       0  100.00%
R/module_filter_manager.R           210       7  96.67%   119-120, 316, 343, 355, 362-363
R/module_nested_tabs.R              411      42  89.78%   120, 178-183, 211, 315-330, 350-354, 409, 527-530, 534-537, 541-544
R/module_session_info.R              18       0  100.00%
R/module_snapshot_manager.R         276       9  96.74%   315-319, 386, 389-391
R/module_source_code.R               69       0  100.00%
R/module_teal_lockfile.R            131      53  59.54%   45-57, 60-62, 76, 86-88, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186
R/module_teal_reporter.R            122       9  92.62%   60, 77-78, 81, 98, 128, 142, 144, 158
R/module_teal.R                     309      26  91.59%   136, 185, 241, 271-291, 321-322
R/module_transform_data.R           164      25  84.76%   77-81, 85-89, 106, 112, 119-120, 134-138, 188, 273-277
R/module_validate_error.R            73       0  100.00%
R/modules.R                         345      50  85.51%   170-174, 229-232, 332, 339, 353, 472, 570-576, 706-712, 725-733, 748-763, 796, 808-816
R/reporter_previewer_module.R        41      12  70.73%   41, 45, 68-85
R/teal_data_module-eval_code.R       23       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 23       0  100.00%
R/teal_data_utils.R                  49       0  100.00%
R/teal_modifiers.R                   57       0  100.00%
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      48       2  95.83%   153-154
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   363     255  29.75%   68-73, 125, 133-162, 193-202, 212, 227-275, 300-575, 603-628, 683, 685-688, 707-721, 738-739, 750-767
R/utils.R                           290      48  83.45%   404-453, 541-550
R/validate_inputs.R                  57       0  100.00%
R/validations.R                      58       0  100.00%
R/zzz.R                              23       1  95.65%   25
TOTAL                              3931     625  84.10%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 7278b8f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   36 suites   2m 52s ⏱️
485 tests 417 ✅ 68 💤 0 ❌
752 runs  684 ✅ 68 💤 0 ❌

Results for commit 7278b8f.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $140.05$ $-3.36$ $0$ $0$ $0$ $0$
shinytest2-disable_report 👶 $+0.37$ $+4$ $+4$ $0$ $0$
shinytest2-disable_src 👶 $+0.20$ $+2$ $+2$ $0$ $0$
shinytest2-show-rcode 👶 $+0.28$ $+3$ $+3$ $0$ $0$
shinytest2-teal_modifiers 👶 $+0.54$ $+7$ $+7$ $0$ $0$
shinytest2-validate_input 💚 $30.65$ $-30.21$ $-4$ $+2$ $0$ $0$
utils 💚 $1.39$ $-1.06$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_teal 💚 $1.96$ $-1.21$ teal_reporter_Add_to_report_button_contains_not_support_reporter_reason_when_module_s_server_returns_empty_teal_card
module_teal 💔 $0.67$ $+1.45$ teal_src_Show_R_code_button_contains_is_disabled_reason_when_disabled_source_code
shinytest2-decorators 💀 $0.03$ $-0.03$ unnamed
shinytest2-disable_report 👶 $+0.09$ Add_to_report_button_is_not_disabled_by_default.
shinytest2-disable_report 👶 $+0.09$ Report_button_is_active_on_a_nested_module_by_default
shinytest2-disable_report 👶 $+0.09$ Report_button_is_disabled_on_a_module_changed_by_disable_report_
shinytest2-disable_report 👶 $+0.09$ Report_button_is_disabled_on_nested_modules_changed_by_disable_report_
shinytest2-disable_src 👶 $+0.10$ Show_R_Code_button_is_disabled_on_a_module
shinytest2-disable_src 👶 $+0.11$ Show_R_Code_is_disabled_on_nested_modules_changed_with_disable_src
shinytest2-reporter 💀 $0.02$ $-0.02$ unnamed
shinytest2-show-rcode 👶 $+0.09$ e2e_Module_with_Show_R_Code_has_code
shinytest2-show-rcode 👶 $+0.09$ e2e_Module_with_Show_R_Code_has_modal_with_two_dismiss_and_two_copy_to_clipboard_buttons
shinytest2-show-rcode 👶 $+0.09$ e2e_Module_with_Show_R_Code_initializes_with_visible_button
shinytest2-teal_data_module 💀 $0.02$ $-0.02$ unnamed
shinytest2-teal_modifiers 👶 $+0.07$ e2e_add_landing_modal_displays_landing_modal_on_app_startup
shinytest2-teal_modifiers 👶 $+0.08$ e2e_add_landing_modal_modal_can_be_dismissed
shinytest2-teal_modifiers 👶 $+0.09$ e2e_combined_modifiers_displays_all_customizations_when_chained_together
shinytest2-teal_modifiers 👶 $+0.07$ e2e_modify_footer_displays_custom_footer_in_the_app
shinytest2-teal_modifiers 👶 $+0.07$ e2e_modify_header_displays_custom_header_in_the_app
shinytest2-teal_modifiers 👶 $+0.07$ e2e_modify_title_sets_custom_title_in_the_page_title_head_title_displays_custom_favicon_in_the_app
shinytest2-teal_modifiers 👶 $+0.08$ e2e_modify_title_sets_custom_title_in_the_page_title_head_title_displays_custom_title_in_the_app
shinytest2-validate_input 💚 $15.68$ $-15.60$ validate_input_shinytest2_sequence_of_errors_with_parallel_validation
shinytest2-validate_input 💚 $14.91$ $-14.83$ validate_input_shinytest2_stale_messages_are_not_shown
utils 💚 $1.10$ $-1.06$ build_app_title_builts_a_valid_tag

Results for commit 85844a3

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the typo that makes the spellcheck fail I think this is a good and short PR.

One minor comment maybe instead of the full output of select_decorators() we could pass it to str() for a shorter and similar ilustrative output

Comment thread R/decorators-helpers.R Outdated
@llrs-roche llrs-roche self-assigned this Aug 28, 2026
wangben718 and others added 4 commits August 28, 2026 08:53
Co-authored-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com>
Signed-off-by: Bingjun(Benjamin) Wang <85646030+wangben718@users.noreply.github.com>
@wangben718
wangben718 requested a review from llrs-roche August 28, 2026 18:13

@llrs-roche llrs-roche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged

@wangben718
wangben718 enabled auto-merge (squash) August 31, 2026 16:43
@wangben718
wangben718 merged commit 3434d34 into main Aug 31, 2026
29 checks passed
@wangben718
wangben718 deleted the 1733-feature-request-export-select_decorators branch August 31, 2026 16:53
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Export `select_decorators

2 participants