-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add prefix filter to team sync groups data source #3248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
laughedelic
wants to merge
4
commits into
integrations:main
Choose a base branch
from
laughedelic:feat/team-sync-groups-q
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5d0f585
feat: add prefix_filter to team sync groups data source
laughedelic 4f9be63
Update docs to include prefix_filter argument and example
laughedelic de55491
fix: address review feedback on prefix_filter
laughedelic d2915b1
docs: generate the data source page from schema and examples
laughedelic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,45 @@ | ||
| --- | ||
| page_title: "github_organization_team_sync_groups (Data Source) - GitHub" | ||
| subcategory: "" | ||
| description: |- | ||
| Get the external identity provider (IdP) groups for an organization. | ||
| --- | ||
|
|
||
| # github_organization_team_sync_groups (Data Source) | ||
|
|
||
| Use this data source to retrieve the identity provider (IdP) groups for an organization. | ||
| Get the external identity provider (IdP) groups for an organization. | ||
|
|
||
| ## Example Usage | ||
|
|
||
| ```terraform | ||
| data "github_organization_team_sync_groups" "test" {} | ||
| # Retrieve all IdP groups for the organization. | ||
| data "github_organization_team_sync_groups" "all" {} | ||
| ``` | ||
|
|
||
| ## Attributes Reference | ||
| ```terraform | ||
| # Retrieve IdP groups whose names begin with a given prefix. | ||
| data "github_organization_team_sync_groups" "filtered" { | ||
| prefix_filter = "myprefix_" | ||
| } | ||
| ``` | ||
|
|
||
| - `groups` - An Array of GitHub Identity Provider Groups. Each `group` block consists of the fields documented below. | ||
| <!-- schema generated by tfplugindocs --> | ||
| ## Schema | ||
|
|
||
| --- | ||
| ### Optional | ||
|
|
||
| - `prefix_filter` (String) Filters the results to return only those that begin with the specified value. | ||
|
|
||
| ### Read-Only | ||
|
|
||
| The `group` block consists of: | ||
| - `groups` (List of Object) (see [below for nested schema](#nestedatt--groups)) | ||
| - `id` (String) The ID of this resource. | ||
|
|
||
| - `group_id` - The ID of the IdP group. | ||
| <a id="nestedatt--groups"></a> | ||
| ### Nested Schema for `groups` | ||
|
|
||
| - `group_name` - The name of the IdP group. | ||
| Read-Only: | ||
|
|
||
| - `group_description` - The description of the IdP group. | ||
| - `group_description` (String) | ||
| - `group_id` (String) | ||
| - `group_name` (String) |
2 changes: 2 additions & 0 deletions
2
examples/data-sources/github_organization_team_sync_groups/data-source_1.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Retrieve all IdP groups for the organization. | ||
| data "github_organization_team_sync_groups" "all" {} |
4 changes: 4 additions & 0 deletions
4
examples/data-sources/github_organization_team_sync_groups/data-source_2.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Retrieve IdP groups whose names begin with a given prefix. | ||
| data "github_organization_team_sync_groups" "filtered" { | ||
| prefix_filter = "myprefix_" | ||
| } |
1 change: 0 additions & 1 deletion
1
examples/data-sources/organization_team_sync_groups/example_1.tf
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 0 additions & 27 deletions
27
templates/data-sources/organization_team_sync_groups.md.tmpl
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming there are rules on the naming of team sync groups? If so we need to validate here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's anything to validate here. These names come from the external identity provider rather than from GitHub, so the permitted characters are whatever the IdP allows. Entra ID group names, Okta group names, etc. From my experience with Okta, there isn't any expected format.