add RequestCRC flag of hevc picture parameters and crc valuses are requested if set to 1#211
Closed
Jexu wants to merge 0 commit intointel:masterfrom
Closed
add RequestCRC flag of hevc picture parameters and crc valuses are requested if set to 1#211Jexu wants to merge 0 commit intointel:masterfrom
Jexu wants to merge 0 commit intointel:masterfrom
Conversation
fhvwy
reviewed
Jul 1, 2018
| /** current picture has only intra slices */ | ||
| uint32_t IntraPicFlag : 1; | ||
| /** CRC valuses are requested if set to 1 */ | ||
| uint32_t RequestCRC : 1; |
Contributor
There was a problem hiding this comment.
Since you're adding this to H.265 standard parts, presumably this is the CRC as defined in §D.3.20?
How will the CRC values for each colour component be retrieved from the decoder?
Contributor
Author
There was a problem hiding this comment.
It is defined in that. @XinfengZhang adds an interface to get the calculated values from decoder in PR #213
Contributor
There was a problem hiding this comment.
Add a bit more comment to explain it?
Will anyone ever want the other hash types? If so, it might be better to add a separate uint8_t hash_type (as table D-10) and then make this bit be request_hash (or something along those lines).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.