-
Notifications
You must be signed in to change notification settings - Fork 86
Fst Writer #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
desmonddak
wants to merge
17
commits into
intel:main
Choose a base branch
from
desmonddak:fst
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fst Writer #671
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
caecb02
keyring-style dart installation rather than holding keys
desmonddak 089faf8
new dart analyzer failure with bad override
desmonddak e015889
Merge branch 'override-bug' into new-dart
desmonddak 1232afb
Potential fix for pull request finding
desmonddak a87fa5c
added back pubkeys, and made a wget a fallback solution with loud war…
desmonddak 949665a
Add FST (Fast Signal Trace) binary waveform writer
desmonddak 84e5ae4
Merge branch 'new-dart' into fst
desmonddak 4895f32
format issues
desmonddak cd713c8
format issues
desmonddak a773746
Restrict fst_writer_test to VM platform
desmonddak a6c6f3b
Merge branch 'main' into fst
desmonddak a6e5457
narrow the fst PR -- it should come first
desmonddak dc57d21
reset to be merged after module_services_api, add significant test
desmonddak dc8f756
Merge branch 'main' into fst
desmonddak 6a39eea
cleanup vcd from waveform_service_test.dart
desmonddak f0fcb9f
Merge branch 'fst' of https://github.com/desmonddak/rohd into fst
desmonddak 747da23
Merge remote-tracking branch 'upstream/main' into fst
desmonddak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // Copyright (C) 2026 Intel Corporation | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
| // | ||
| // diagnostics.dart | ||
| // Barrel export for the diagnostics library. | ||
| // | ||
| // 2026 July 16 | ||
| // Author: Desmond Kirkpatrick <desmond.a.kirkpatrick@intel.com> | ||
|
|
||
| export 'module_service.dart'; | ||
| export 'module_services.dart'; | ||
| export 'waveform_service.dart'; | ||
| export 'waveform_writer.dart'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Copyright (C) 2026 Intel Corporation | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
| // | ||
| // module_service.dart | ||
| // Common base types shared by all module-scoped services. | ||
| // | ||
| // 2026 June 23 | ||
| // Author: Desmond Kirkpatrick <desmond.a.kirkpatrick@intel.com> | ||
|
|
||
| import 'package:rohd/rohd.dart'; | ||
|
|
||
| /// The common contract implemented by every module-scoped service that | ||
| /// registers with [ModuleServices]. | ||
| abstract interface class ModuleService { | ||
| /// The top-level [Module] this service operates on. | ||
| Module get module; | ||
|
|
||
| /// A JSON-serialisable summary of this service. | ||
| Map<String, Object?> toJson(); | ||
| } | ||
|
|
||
| /// A [ModuleService] that emits output to one or more files. | ||
| abstract class OutputService implements ModuleService { | ||
| /// The default location written by [write]. | ||
| String? get outputPath; | ||
|
|
||
| /// Whether [write] emits one file per module definition (`true`) or a single | ||
| /// combined file (`false`). | ||
| bool get multiFile; | ||
|
|
||
| /// Writes this service's output to [path], or to [outputPath] when [path] is | ||
| /// omitted. | ||
| void write([String? path]); | ||
| } | ||
|
|
||
| /// An [OutputService] that generates source-code text, keyed per module | ||
| /// definition. | ||
| abstract class CodeGenService extends OutputService { | ||
| /// The combined single-file generated output (including any header). | ||
| String get output; | ||
|
|
||
| /// The generated output keyed by module definition name | ||
| /// ([Module.definitionName]). | ||
| Map<String, String> get contentsByDefinitionName; | ||
|
|
||
| /// The generated output for a single module [definitionName], or `null` when | ||
| /// that definition was not generated. | ||
| String? moduleOutput(String definitionName) => | ||
| contentsByDefinitionName[definitionName]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright (C) 2026 Intel Corporation | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
| // | ||
| // module_services.dart | ||
| // Slim, type-keyed registry of module-scoped services for DevTools and other | ||
| // inspection tools. | ||
| // | ||
| // 2026 April 25 | ||
| // Author: Desmond Kirkpatrick <desmond.a.kirkpatrick@intel.com> | ||
|
|
||
| import 'package:rohd/rohd.dart'; | ||
| import 'package:rohd/src/diagnostics/inspector_service.dart'; | ||
|
|
||
| /// A slim, type-keyed registry of [ModuleService]s. | ||
| class ModuleServices { | ||
| ModuleServices._(); | ||
|
|
||
| /// The singleton instance. | ||
| static final ModuleServices instance = ModuleServices._(); | ||
|
|
||
| Module? _rootModule; | ||
|
|
||
| /// The most recently built top-level [Module]. | ||
| Module? get rootModule => _rootModule; | ||
|
|
||
| set rootModule(Module? value) { | ||
| _rootModule = value; | ||
| ModuleTree.rootModuleInstance = value; | ||
| } | ||
|
|
||
| /// Returns the module hierarchy as a JSON string. | ||
| String get hierarchyJSON => ModuleTree.instance.hierarchyJSON; | ||
|
|
||
| final Map<Type, ModuleService> _services = <Type, ModuleService>{}; | ||
|
|
||
| /// Registers [service] under the type argument [T]. | ||
| void register<T extends ModuleService>(T service) { | ||
| _services[T] = service; | ||
| } | ||
|
|
||
| /// Returns the registered service of type [T], or `null` if none. | ||
| T? lookup<T extends ModuleService>() => _services[T] as T?; | ||
|
|
||
| /// Removes the registered service of type [T], if any. | ||
| void unregister<T extends ModuleService>() { | ||
| _services.remove(T); | ||
| } | ||
|
|
||
| /// Resets all services. Intended for test teardown. | ||
| void reset() { | ||
| rootModule = null; | ||
| _services.clear(); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.