Skip to content

[PB-6281]: add DocumentsProvider write/upload pipeline#469

Merged
terrerox merged 1 commit into
release-1.9.1from
feature/PB-6281-documents-provider-write
Jun 10, 2026
Merged

[PB-6281]: add DocumentsProvider write/upload pipeline#469
terrerox merged 1 commit into
release-1.9.1from
feature/PB-6281-documents-provider-write

Conversation

@terrerox

Copy link
Copy Markdown
  • enable write mode in openDocument using pending upload tokens
  • implement createDocument flow with unique-name resolution and stale token cleanup
  • add pipe-to-temp encryption + upload orchestration (single and multipart)
  • finish bridge upload and create drive file entry with metadata timestamps
  • refactor decrypt callback handling via awaitCryptoService and shared auth error constant

@terrerox terrerox marked this pull request as draft May 28, 2026 04:47
@terrerox terrerox self-assigned this May 28, 2026
@terrerox terrerox marked this pull request as ready for review May 28, 2026 04:55
@terrerox terrerox requested a review from CandelR June 1, 2026 14:38
@terrerox terrerox force-pushed the feature/PB-6281-upload-file branch from 5b81068 to 19346e5 Compare June 1, 2026 22:19
@terrerox terrerox requested a review from TamaraFinogina as a code owner June 1, 2026 22:19
@terrerox terrerox force-pushed the feature/PB-6281-upload-file branch 2 times, most recently from 5b81068 to abd0357 Compare June 1, 2026 22:37
@terrerox terrerox force-pushed the feature/PB-6281-documents-provider-write branch from 68bdcde to 90eaa8a Compare June 1, 2026 22:47
- enable write mode in openDocument using pending upload tokens
- implement createDocument flow with unique-name resolution and stale token cleanup
- add pipe-to-temp encryption + upload orchestration (single and multipart)
- finish bridge upload and create drive file entry with metadata timestamps
- refactor decrypt callback handling via awaitCryptoService and shared auth error constant
@terrerox terrerox force-pushed the feature/PB-6281-documents-provider-write branch from 90eaa8a to a227a68 Compare June 5, 2026 14:48
@sonarqubecloud

sonarqubecloud Bot commented Jun 5, 2026

Copy link
Copy Markdown

@terrerox terrerox requested a review from xabg2 June 9, 2026 13:09

@CandelR CandelR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is at 858 lines now. Might be worth splitting before it gets harder to navigate:

  • FolderListingCache: FolderLoad, folderLoads, and the cache/notification helpers (startBackgroundLoad, appendRows, finishLoad, patchRowDisplayName, removeRow, invalidateChildren, notifyChildren).

  • upload/DocumentUploadOrchestrator: the full write side: pending upload registry, name resolution, and the pipeline (openForWrite -> runUpload -> encryptInputToTemp -> uploadEncryptedFile -> finalizeAndRecordFile). Provider just calls createDocument, openForWrite, queryPendingUpload.

  • download/DocumentDownloadOrchestrator: openDocumentBlocking, materializeIntoCache, openCached, decryptBlocking. Nothing fancy, already pretty self-contained.

Provider ends up around 200 lines, just the SAF contract and wiring. Shared utils (apiClient, streamPages, mutate, rawUuid) can stay, not worth the extra hop.

The proposal no blocks this PR at all, just flagging it for a follow-up.

Base automatically changed from feature/PB-6281-upload-file to release-1.9.1 June 10, 2026 20:24
@terrerox terrerox merged commit e810261 into release-1.9.1 Jun 10, 2026
2 of 3 checks passed
@terrerox terrerox deleted the feature/PB-6281-documents-provider-write branch June 10, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants