[PB-6467: feature/Migrate Photos backup to use new Photos enpdoints#477
Open
CandelR wants to merge 4 commits into
Open
[PB-6467: feature/Migrate Photos backup to use new Photos enpdoints#477CandelR wants to merge 4 commits into
CandelR wants to merge 4 commits into
Conversation
… photos device service tests
larryrider
reviewed
Jun 5, 2026
| }); | ||
| }; | ||
|
|
||
| beforeEach(() => { |
There was a problem hiding this comment.
isnt it better to include this beforeEach inside the 'describe' test?
There was a problem hiding this comment.
or maybe add a parent describe test so it includes all the sub-describes of this file
Contributor
Author
There was a problem hiding this comment.
the option of the parent describe seems good, adding it 🔝
Base automatically changed from
feature/PB-6098-handle-storage-quota-in-photos
to
feature/PB-6068-photos-backup
June 8, 2026 14:34
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace photos folder creation logic with the new
Photosbackend endpointsSummary
photosDeviceService.ts: HTTP client forphotosendpoints (To use sdk functions we will need to merge [v1.9.1] - Release 1.9.1 #473 first, will be done in another task)PhotoDeviceId.ts:PhotoDeviceManager: replaces client generated UUID withensureDeviceFolder(), which calls the new endpoint and returns{ deviceId, plainName, bucket }wheredeviceIdis the backend folder uuid. iOS recovery via Keychain; Android recovery viaandroidIdon 409 conflictPhotoBackupFolders.ts: removed root and device folder creation. Now only managesyear/month/dayhierarchy under thedeviceFolderUuidprovided by the callerPhotoCloudBrowser.ts:listDeviceFolders()now queriesphotosDeviceService.listDevices()store/slices/photos/index.ts:initDeviceIdThunkusesPhotoDeviceManager.ensureDeviceFolder()and storesphotosBucketalongsidedeviceId