[PB-6477]: migrate DocumentsProvider IO to kotlinx coroutines#482
Open
terrerox wants to merge 2 commits into
Open
[PB-6477]: migrate DocumentsProvider IO to kotlinx coroutines#482terrerox wants to merge 2 commits into
terrerox wants to merge 2 commits into
Conversation
Replace CompletableFuture.get(), Call.execute() and the manual AtomicReference + setOnCancelListener cancellation plumbing with kotlinx-coroutines across the native DocumentsProvider stack: crypto, download and upload now suspend via Call.await()/CallAwait and CryptoServiceAwait, and openDocument bridges to coroutines through runBlockingIo (BlockingIo) instead of a plain runBlocking, surfacing cancellation as FileNotFoundException. Adds kotlinx-coroutines-android and kotlinx-coroutines-test to android/app/build.gradle and JVM unit tests for BlockingIo, CryptoServiceAwait, EncryptedFileDownloader and EncryptedFileUploader. NOTE: a separate, unrelated change by the maintainer lives in the same file (InternxtDocumentsProvider.kt) and could not be split out because interactive staging (git add -p) is unavailable and editing source is out of scope for the git-manager: refresh() now triggers a background revalidateChildren (new revalidate/fetchAllRows helpers and the FolderLoad.isRevalidating flag) instead of invalidateChildren. It is bundled here intentionally; see progress/git_android_coroutines_migration.md. Refs: PB-6282
…toServiceAwaitTest
|
xabg2
reviewed
Jun 10, 2026
| is FileNotFoundException -> e | ||
| is OperationCanceledException -> | ||
| FileNotFoundException("openDocument $id cancelled").apply { initCause(e) } | ||
| is CancellationException -> e |
Contributor
|
Also, check the Unit tests @terrerox |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace CompletableFuture.get(), Call.execute() and the manual AtomicReference + setOnCancelListener cancellation plumbing with kotlinx-coroutines across the native DocumentsProvider stack: crypto, download and upload now suspend via Call.await()/CallAwait and CryptoServiceAwait, and openDocument bridges to coroutines through runBlockingIo (BlockingIo) instead of a plain runBlocking, surfacing cancellation as FileNotFoundException. Adds kotlinx-coroutines-android and kotlinx-coroutines-test to android/app/build.gradle and JVM unit tests for BlockingIo, CryptoServiceAwait, EncryptedFileDownloader and EncryptedFileUploader.