[PB-6480] feature/Filmstrip scrub and scroll restoration in photo viewer#488
Open
CandelR wants to merge 1 commit into
Open
[PB-6480] feature/Filmstrip scrub and scroll restoration in photo viewer#488CandelR wants to merge 1 commit into
CandelR wants to merge 1 commit into
Conversation
…sset preview state management and scroll restoration
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add filmstrip scrub and scroll restoration to the photo preview screen
Summary
PreviewCarousel: drag on the thumbnail strip now changes the main preview photo in real time. UsesisUserScrollingRefto stay active through the momentum phase so the final settled index is captured correctly.filmstripPaddingcorrected to center the active thumb (screenWidth/2 - (THUMB_W_ACTIVE/2 + THUMB_ACTIVE_MARGIN)) instead of the inactive slot midpoint.PreviewPager: receivesisScrubbingprop and reads it via ref (isScrubbingRef) excluded fromuseEffectdeps. Prevents an oscillation loop where scrub-end would trigger an animated scroll, fireonMomentumScrollEnd, and restart the cycle.usePreviewSource: full resolution fetch is deferred while scrubbing. Replaceduri: string | null | undefinedwithuri: string | null+isLoading: booleanso loading state is explicit rather than encoded asundefined.PreviewPage: drillsisScrubbingtousePreviewSource. PassesisLoadingtoPageContentreplacing theuri === undefinedspinner check.PhotoPreviewScreen/index: ownsisScrubbingstat. Reports the current item id toPhotosScreenviaonCurrentItemChangeroute param on every index change.PhotosTimeline: converted toforwardRefexposingscrollToAssetId(id).PhotosScreen/index: stores the last viewed photo id inlastViewedIdRef. OnuseFocusEffectscrolls the grid back to that photo and clears the ref.