cli: load the ISC form from the default maps endpoint - #70
Merged
Merged
Conversation
The default strategy chain had no ISC loader, so the CLI could not load any map from interscript.org/maps (which serves .isc only) - the published CLI has been unusable without a local maps checkout. Verified against the live endpoint: echo Антон | interscript t bgnpcgn-ukr... -> Anton.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
iscStrategyto the CLI's default loader chain (before the compiled-JSONhttpStrategyfallback).Why
interscript.org/mapsserves the ISC form only; the CLI's default chain had no ISC loader, so every invocation without a local maps checkout failed withMap not found. The published CLI has been unusable as shipped.Verification
Built locally and run against the live endpoint:
echo "Антон" | node dist/cli.js t bgnpcgn-ukr-Cyrl-Latn-2019→Anton. tsc, eslint, prettier clean; examples suite green.