Skip to content

Truncate entered password to match lemmy/piefed limits. #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwr1 merged 1 commit into from
Apr 27, 2026
Merged

Truncate entered password to match lemmy/piefed limits. #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/src/controller/controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,10 @@ class AppController with ChangeNotifier {
ServerSoftware.piefed => 'username',
ServerSoftware.mbin => throw UnreachableError(),
}: username,
'password': password,
'password': password?.substring(
0,
software == ServerSoftware.lemmy ? 60 : 128,
),
if (software == ServerSoftware.lemmy) 'totp_2fa_token': totp,
}),
);
Expand Down
6 changes: 4 additions & 2 deletions lib/src/screens/settings/login_confirm.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class _LoginConfirmScreenState extends State<LoginConfirmScreen> {
padding: const EdgeInsets.all(16),
child: AutofillGroup(
child: Column(
spacing: 12,
children: [
TextEditor(
_usernameEmailTextController,
Expand All @@ -63,13 +64,14 @@ class _LoginConfirmScreenState extends State<LoginConfirmScreen> {
AutofillHints.email,
],
),
const SizedBox(height: 12),
PasswordEditor(
_passwordTextController,
onChanged: (_) => setState(() {}),
maxLength: widget.software == ServerSoftware.lemmy
? 60
: 128,
),
if (widget.software == ServerSoftware.lemmy) ...[
const SizedBox(height: 12),
TextEditor(
_totpTokenTextController,
label: l(context).totpToken,
Expand Down
9 changes: 8 additions & 1 deletion lib/src/widgets/password_editor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,16 @@ import 'package:flutter/material.dart';
import 'package:interstellar/src/utils/utils.dart';

class PasswordEditor extends StatefulWidget {
const PasswordEditor(this.controller, {this.onChanged, super.key});
const PasswordEditor(
this.controller, {
this.onChanged,
this.maxLength,
super.key,
});

final TextEditingController controller;
final void Function(String)? onChanged;
final int? maxLength;

@override
State<PasswordEditor> createState() => _PasswordEditorState();
Expand Down Expand Up @@ -34,6 +40,7 @@ class _PasswordEditorState extends State<PasswordEditor> {
onChanged: widget.onChanged,
autofillHints: const [AutofillHints.password],
obscureText: obscureText,
maxLength: widget.maxLength,
);
}
}
Loading