This repository was archived by the owner on Oct 4, 2026. It is now read-only.
Repository navigation
fix(docs): derive GitHub Pages base path from the building repository - #395
Merged
Merged
Conversation
Copies and forks of the repo built for invoke.ai, so assets and links broke under /<repo>/. Only invoke-ai/InvokeAI now builds the custom target; others build ghpages with site and base taken from GITHUB_REPOSITORY, shared by the Astro config and the deploy-output check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs deployed from this repo to https://invoke-ai.github.io/InvokeAI-7/ have no styles and broken links. Push builds always used the
customtarget (invoke.ai, base''), so every asset and link was root-relative (/_astro/…) and resolved outside/InvokeAI-7/. The manualghpagesoption didn't help either: it hardcoded/InvokeAI.docs/src/lib/deploy-target.mjsresolves the target. Aghpagesbuild takes its site and base fromGITHUB_REPOSITORY(https://<owner>.github.io+/<repo>) and falls back to/InvokeAIoutside Actions.astro.config.mjsandverify-deploy-output.mjsboth use it, so the build and the check stay in sync.deploy-docs.ymlpicks the target per repository.invoke-ai/InvokeAIbuildscustom; any other repo (this one, forks) buildsghpages.workflow_dispatchgets a new default,auto, andcustom/ghpagesstill override it. The target is set once in the job env and shared by the build and verify steps.custombuilds onmain. This repo's broken deploy had been reporting page views to invoke.ai's Plausible account.Edit links, the GitHub social link and the changelogs source still point to
invoke-ai/InvokeAIon purpose: edits should go upstream.QA Instructions
From
docs/:pnpm test: 19/19 pass, including the newdeploy-target.test.mjs.DEPLOY_TARGET=ghpages GITHUB_REPOSITORY=invoke-ai/InvokeAI-7 pnpm build && pnpm run check-deploy-outputpasses. Assets are at/InvokeAI-7/_astro/…and the canonical URL ishttps://invoke-ai.github.io/InvokeAI-7/. Pagefind, the sitemap,llms.txt, font URLs and redirect pages all carry the/InvokeAI-7base.DEPLOY_TARGET=custom … pnpm build && pnpm run check-deploy-outputpasses, and the output is unchanged (canonicalhttps://invoke.ai/).ghpagesdist through the verifier ascustom, fails with 13 errors.The live deploy can only be checked after merge, because Pages deploys run only from
main.Review
No material findings. Known limits that are not regressions:
public/CNAME(invoke.ai) still ships in this repo's artifact. Actions-based Pages deploys ignore it.<owner>.github.iowould get a/<owner>.github.iobase. No such repo exists.Compatibility / Rollout
Upstream
invoke-ai/InvokeAIkeeps buildingcustomexactly as before. In this repo, the next docs-related push tomain(merging this PR counts) deploys the corrected site.Checklist
What's Newcopy (if doing a release after this PR)🤖 Generated with Claude Code