Skip to content

feat(krea2): run Krea-2 attention on SageAttention when enabled - #9662

Merged
lstein merged 12 commits into
invoke-ai:mainfrom
Pfannkuchensack:feat/sage-attention-krea2
Oct 16, 2026
Merged

lstein merged 12 commits into
invoke-ai:mainfrom
Pfannkuchensack:feat/sage-attention-krea2

Conversation

@Pfannkuchensack

@Pfannkuchensack Pfannkuchensack commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Note

Stacked PR 5 of 8: merge after #9661. It targets main, so until the PRs before it merge, its diff also shows their commits and the merges that carry them forward. This PR's own change is one commit, 482e7f348f.

Summary

With attention_backend: sage, Krea-2 denoising enters the SageAttention scope from #9657, so its eligible attention calls run on SageAttention; its grouped-query attention (48 query and 12 K/V heads) runs natively, without expanding K/V. While INVOKE_KREA2_SDPA_BACKEND pins a PyTorch kernel for measurement, the scope stays closed so the pinned kernel is what runs. The default auto is unchanged. The docs page lists Krea-2 under Supported models.

Related Issues / Discussions

Stacked on #9657 (SageAttention backend) and #9661, the PR before it.

QA Instructions

Krea-2 Turbo GGUF Q4_K_M, model loaded, arms as described in #9657:

1024² 2048²
Step, SDPA (Krea-2's own cuDNN-first policy) 1254 ms 4976 ms
Step, SageAttention 1214 ms (−3 %) 4186 ms (−16 %)
Whole generation 11.5 → 11.0 s (−4 %) 42.7 → 36.2 s (−15 %)
Peak VRAM in the denoise scope unchanged unchanged
LPIPS against SDPA, median (no floor, see below) 0.058 0.238
  • Krea-2 already ranks cuDNN first in its own SDPA policy, so the cuDNN-first arm is identical to the default and gives no noise floor: every composition change shows up in LPIPS. The pairs with the largest LPIPS (0.305 at 2048², 0.192 at 1024²) show the same scene with a shifted crop or a missing stack of books; hands and fabric are equally sharp at 1:1 and the lettering is correct.
  • Blind side-by-side review: 8 of 8 pairs equal.
  • Accuracy on real activations: block 0 has the same Q/K channel outlier as Qwen-Image (cosine 0.53 with K smoothing, 0.988 without, as feat(attention): add opt-in SageAttention backend for diffusion models #9657 ships).
  • Per step, 28 of the 32 attention calls run on SageAttention; the other 4 are below the size threshold.
  • The timings, LPIPS and blind review come from the measurement prototype, which still had K smoothing on; with the shipped selection one generation measured LPIPS 0.055 against SDPA.

To try it: install SageAttention as the docs page from #9657 describes, set attention_backend: sage, restart and generate with Krea-2. The first generation logs SageAttention ... serves diffusion-model attention on cuda:0 (...) with the GPU and kernel name, and with log_level: debug every generation logs how many calls ran on SageAttention and why the others did not. With attention_backend: auto the output is bit-identical to main.

Checks: ruff clean; pytest tests/app/invocations passes with the whole stack applied (2090 passed). No call-site test was added: this change only enters the scope, whose behavior #9657 tests.

Review

Resolved: with INVOKE_KREA2_SDPA_BACKEND set, SageAttention served the calls the override was meant to measure; the scope now stays closed while it is set.

Compatibility / Rollout

Merge after #9661. No API or persisted-state change; only attention_backend: sage behaves differently.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Meaningful regression coverage added / updated where needed; obsolete tests/code removed
  • Persisted-state and API changes include required migrations / compatibility validation
  • Relevant performance/efficiency opportunities considered; material claims have evidence
  • Material review findings resolved and relevant checks rerun
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

With `attention_backend: sage`, Qwen-Image denoising enters the SageAttention scope.
RTX 4090, Qwen-Image 2512 GGUF Q4_K_M: 78.8 s → 73.5 s at 1024², 208.9 s → 150.3 s at 2048², peak VRAM unchanged; a blind review judged no image worse.
With `attention_backend: sage`, Krea-2 denoising enters the SageAttention scope unless INVOKE_KREA2_SDPA_BACKEND pins a PyTorch kernel.
RTX 4090, Krea-2 Turbo GGUF Q4_K_M: 11.5 s → 11.0 s at 1024², 42.7 s → 36.2 s at 2048², peak VRAM unchanged; a blind review judged no image worse.
@github-actions github-actions Bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files services PRs that change app services python-tests PRs that change python tests docs PRs that change docs labels Oct 3, 2026
@Pfannkuchensack
Pfannkuchensack marked this pull request as ready for review October 12, 2026 20:44

@JPPhoto JPPhoto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lstein
lstein enabled auto-merge October 16, 2026 13:13
@lstein
lstein merged commit eeff74a into invoke-ai:main Oct 16, 2026
17 checks passed
lstein added a commit that referenced this pull request Oct 17, 2026
> [!NOTE]
> Stacked PR 6 of 8: merge after #9662. It targets `main`, so until the
PRs before it merge, its diff also shows their commits and the merges
that carry them forward. This PR's own change is one commit,
[`1968eb9c58`](Pfannkuchensack@1968eb9).

## Summary

With `attention_backend: sage`, SDXL denoising and SDXL tiled
multi-diffusion enter the SageAttention scope from #9657, so eligible
attention calls run on SageAttention, including ControlNets that run
inside the loop. SD1.5 and SD2 do not enter it: SD1.5's head sizes (40,
80, 160) never qualify, and SD2 is unmeasured. With `attention_type:
sliced`, SDXL's attention does not go through SDPA, so nothing changes
there. The default `auto` is unchanged. The docs page lists SDXL under
Supported models and notes the sliced case.

## Related Issues / Discussions

Stacked on #9657 (SageAttention backend) and #9662, the PR before it.

## QA Instructions

SDXL, model loaded, three arms per seed as described in #9657:

|  | 1024² | 2048² |
| --- | --- | --- |
| Step, default SDPA | 134 ms | 631 ms |
| Step, cuDNN-first SDPA | 135 ms | 579 ms |
| Step, SageAttention | 126 ms (−6 %) | 496 ms (−21 %) |
| Whole generation | 4.4 → 4.2 s (−5 %) | 19.6 → 16.1 s (−18 %) |
| Peak VRAM in the denoise scope | unchanged | unchanged |
| LPIPS against default SDPA, median (cuDNN-first) | 0.027 (0.015) |
0.014 (0.006) |

- At 1024², 10 of the 140 attention calls per UNet pass qualify: the
4096-token self-attention of the outer blocks. The 1024-token
self-attention of the inner blocks and all 77-token text cross-attention
are below the break-even and stay on SDPA. At 2048² the inner blocks
qualify too.
- Blind side-by-side review: 7 of 8 pairs equal, 1 judged better with
SageAttention.
- Accuracy on real activations, every call of step 0 (10 calls): cosine
1.0000, relative L2 0.003.
- The timings, LPIPS and blind review come from the measurement
prototype, which still used `sageattn()`'s default K smoothing; the
selection #9657 ships is faster per call.

To try it: install SageAttention as the docs page from #9657 describes,
set `attention_backend: sage`, restart and generate with SDXL. The first
generation logs `SageAttention ... serves diffusion-model attention on
cuda:0 (...)` with the GPU and kernel name, and with `log_level: debug`
every generation logs how many calls ran on SageAttention and why the
others did not. With `attention_backend: auto` the output is
bit-identical to `main`.

Checks: ruff clean; `pytest tests/app/invocations` passes with the whole
stack applied (2090 passed). No call-site test was added: this change
only enters the scope, whose behavior #9657 tests.

## Review

Resolved: the scope first opened for every UNet base, including the
unmeasured SD2; it now opens for SDXL only.

## Compatibility / Rollout

Merge after #9662. No API or persisted-state change; only
`attention_backend: sage` behaves differently.

## Checklist

- [x] _The PR has a short but descriptive title, suitable for a
changelog_
- [ ] _Meaningful regression coverage added / updated where needed;
obsolete tests/code removed_
- [ ] _Persisted-state and API changes include required migrations /
compatibility validation_
- [x] _Relevant performance/efficiency opportunities considered;
material claims have evidence_
- [x] _Material review findings resolved and relevant checks rerun_
- [x] _Documentation added / updated (if applicable)_
- [ ] _Updated `What's New` copy (if doing a release after this PR)_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.0.0 backend PRs that change backend files docs PRs that change docs invocations PRs that change invocations python PRs that change python files python-tests PRs that change python tests services PRs that change app services

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants