Repository navigation
test(workflows): fix flaky last_run_at listing test on Windows - #9788
Merged
Merged
Conversation
… the page The listing check now pages user workflows only. On a coarse clock the new workflow ties on created_at with the 43 bundled workflows, and the workflow_id tie-break usually put it past the first 10.
JPPhoto
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_workflow_last_run_at.py::test_update_last_run_at_sets_timestampfails intermittently, mostly on Windows CI.created_at.created_athas millisecond resolution. On Windows' ~15 ms clock the new workflow usually gets the same timestamp as the bundled ones.workflow_iddescending. A random UUID sorts above the bundleddefault_...ids only about 1 time in 7 or 8, so the new workflow usually falls off the page and the test'snext(...)raisesStopIteration.The listing now includes only user workflows, which is what the check is about. Nothing else changes.
Related Issues / Discussions
Seen as the
windows-cpufailure on #9694. The test came in with #9702.QA Instructions
created_atto the same value), 20 runs each: the old query lost the workflow in 19, the new one in none.uv run --no-sync pytest tests/app/services/workflow_records: 137 passed.ruff checkandruff format --checkare clean.Review
No material findings. This is a one-line test change.
Checklist
What's Newcopy (if doing a release after this PR)