Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After uploading a mix of images and videos, the success notice told users "videos appear in Media". Uploaded videos actually land on the Uploads tab (they are sent with
video_category: 'user'and counted on that tab), so users were sent hunting in the wrong place for their files. This changes theuploadSplitlocale string to "Images and videos appear in Uploads." — matching the actual behaviour confirmed by maintainer @lstein on the issue.One line,
en.jsonsource locale only; other locales fall back to English.Related Issues
Fixes part of #9619 (item 7 in @lstein's comment: "upload success notification is now incorrect").
QA Instructions
Review
invokeai/frontend/webv2/public/locales/en.json:4301read "Images appear in Uploads; videos appear in Media."Checklist
Need help on this PR? Tag
@codesmith-botwith what you need.