Skip to content

fix: point mixed-upload success notice at the Uploads tab - #9847

Open
aniketkrs wants to merge 1 commit into
invoke-ai:mainfrom
aniketkrs:docs/fix-upload-split-notice
Open

aniketkrs wants to merge 1 commit into
invoke-ai:mainfrom
aniketkrs:docs/fix-upload-split-notice

Conversation

@aniketkrs

@aniketkrs aniketkrs commented Oct 14, 2026 •

Copy link
Copy Markdown

Summary

After uploading a mix of images and videos, the success notice told users "videos appear in Media". Uploaded videos actually land on the Uploads tab (they are sent with video_category: 'user' and counted on that tab), so users were sent hunting in the wrong place for their files. This changes the uploadSplit locale string to "Images and videos appear in Uploads." — matching the actual behaviour confirmed by maintainer @lstein on the issue.

One line, en.json source locale only; other locales fall back to English.

Related Issues

Fixes part of #9619 (item 7 in @lstein's comment: "upload success notification is now incorrect").

QA Instructions

  1. Upload a mix of images and videos from the gallery upload action.
  2. Read the success notice — it should say images and videos appear in Uploads.
  3. Switch to the Uploads tab and confirm both files are there.

Review

  • Before: invokeai/frontend/webv2/public/locales/en.json:4301 read "Images appear in Uploads; videos appear in Media."
  • After: it reads "Images and videos appear in Uploads." (verified on this branch; no other locale key reuses the old wording).
  • The JSON file was validated after the edit.

Checklist

  • Focused change, single file
  • No behaviour change beyond the corrected string

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 04:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-14T04:13:49.281443Z 04bcb31 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the frontend PRs that change frontend files label Oct 14, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants