Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The FLUX Redux Image influence slider's (?) help card showed the Canvas Denoising Strength text — "Controls how much the generated image varies from the raster layers." — which is completely unrelated to the control and misled users tuning reference-image influence.
The control (FluxReduxControls) was wired to the existing
hints.imageInfluencekey, which holds the Canvas Denoising Strength copy. This adds a dedicatedhints.fluxReduxImageInfluenceentry inen.jsonwith copy describing the actual control (Low/Medium/High/Highest reference-image strength) and points the Field at it. The existinghints.imageInfluenceentry is untouched.Related Issues
Fixes part of #9619 (item 6 in @lstein's comment: "Redux influence needs its own hint text").
QA Instructions
Review
ReferenceImageControls.tsx:369hadhint="imageInfluence", whose locale entry describes Canvas Denoising Strength.hint="fluxReduxImageInfluence";en.jsonhas the new key with the correct copy; the oldhints.imageInfluenceentry is unchanged.en.jsonwas JSON-validated after the edit.Checklist
Need help on this PR? Tag
@codesmith-botwith what you need.