Repository navigation
Conversation
JPPhoto
force-pushed
the
smart-video-concatenation
branch
4 times, most recently
from
October 16, 2026 02:22
f4e1951 to
5bdb16f
Compare
Preserve compatible H.264 segments and fall back to full encoding when needed. Verify smart-render bridge values against independent transition math and full encoding.
Regenerate OpenAPI and TypeScript schemas for video_concat 1.3.0. Update bundled workflows with the version and default-enabled input.
JPPhoto
force-pushed
the
smart-video-concatenation
branch
from
October 16, 2026 02:51
5bdb16f to
4290ea4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#9833 laid the groundwork for adding GOP-aware smart rendering to video concatenation. This PR adds it to
video_concat(version 1.3.0), preserving original H.264 video data outside transition regions when inputs are compatible. It re-encodes transition bridges extended to safe GOP boundaries and falls back to the existing full-encoding path when stream copying is unsafe. Existing transitions and audio assembly are retained.Related Issues / Discussions
Builds on #9833.
QA Instructions
QA Instructions
PYTHONOPTIMIZE=0 OMP_NUM_THREADS=1 uv run --no-sync pytest -p no:cacheprovider tests/app/invocations/test_video_concat_splice.py- 49 passed.Review
Added real-FFmpeg checks comparing decoded smart-render bridge frames with independent transition math and the full-encode path for crossfade and even/odd fades. The transition-value coverage finding is resolved.
Compatibility / Rollout
The
video_concatinvocation is version 1.3.0 and addssmart_render, enabled by default. Existing workflows remain compatible. Unsupported inputs and failed output validation fall back to full encoding; setsmart_renderto false to force that path.Checklist
What's Newcopy (if doing a release after this PR)Need help on this PR? Tag
@codesmith-botwith what you need.