Repository navigation
fix(models): always install in place from the configured models folder - #9869
Merged
Merged
Conversation
Local sources inside the models folder now always install in place; the Install in place option shows checked and disabled there, with a tooltip.
Pfannkuchensack
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Models let users untick Install in place for files already inside Invoke's configured models folder. A non-in-place install from there moves the files into a new managed folder inside that same models folder.
Now any local source inside the models folder always installs in place:
inplace=truefor such sources: Pull, per-row Install, the row's context menu, and Install all.Outside the folder the user's choice applies as before, and it comes back unchanged after they leave the folder.
isInModelsDircompares paths as text against the server-reported folder. It normalizes separators and trailing slashes, compares Windows drive and UNC paths case-insensitively, and never matches a path with..segments.Related Issues / Discussions
Closes #9796
QA Instructions
pnpm check:release(webv2) passed: lint/types/architecture, unit (10187), browser (2896), architecture performance, project-file journeys, accessibility. The first run hit a timeout in the unrelatedSettingsDialogTarget.browser.test.tsx. It passed twice in isolation, and the full rerun passed.New unit cases for
isInModelsDir, and a browser test inAddModelsView.browser.test.tsxcovering:inplace=trueinside it;inplace=truefor every result.The browser test fails on
main.Browser (mock backend
models_dir=/opt/invokeai/models;scan_folderand install POSTs stubbed):/opt/invokeai/models/loras/detail.safetensors: the option is checked and disabled, the tooltip shows on hover, and clicking does nothing.inplace=true. Onmainthe same flow sendsinplace=falseafter unticking.Review
No remaining material findings. Known limits:
inplace=falsefor these paths from the legacy UI or direct API callers, because its install path deliberately supports moving files from inside the models root (recovery sentinels).inplace.~, a symlinked file path typed by hand) fall back to the user's choice.Checklist
What's Newcopy (if doing a release after this PR)Need help on this PR? Tag
@codesmith-botwith what you need.