Repository navigation
fix(make): run frontend pnpm targets from their package directories - #9871
Merged
Merged
Conversation
frontend-api-install and frontend-lint now cd into their package before calling pnpm, so per-directory pnpm resolution (corepack, version managers) picks up each package's pinned packageManager. The typegen docs snippet does the same.
joshistoast
enabled auto-merge
October 15, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make frontend-api-installandmake frontend-lintcalledpnpm -C <package>from the repo root. Tools that resolve pnpm per directory (corepack, version managers) readpackageManagerfrom the current directory, and the root has nopackage.json, so these targets ran the wrong pnpm or failed outright. Both targets nowcdinto their package first, matching the other frontend targets. The typegen snippet in the Front End docs does the same.Related Issues / Discussions
Closes #9870
QA Instructions
With a corepack pnpm shim first on
PATH(corepack enable --install-directory <dir> pnpm) and Node 22.14:make frontend-api-installfails withCannot find module .../corepack/v1/pnpm/12.9.1/bin/pnpm.cjs.make frontend-api-installcompletes using pnpm v10.12.4, andmake frontend-lintpasses.Review
No material findings.
Checklist
What's Newcopy (if doing a release after this PR)Need help on this PR? Tag
@codesmith-botwith what you need.