Skip to content

fix(workflow): recall generation graphs from images - #9906

Merged
joshistoast merged 1 commit into
mainfrom
fix/generate-workflow-metadata
Oct 18, 2026
Merged

joshistoast merged 1 commit into
mainfrom
fix/generate-workflow-metadata

Conversation

@joshistoast

@joshistoast joshistoast commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Generate images already contain their execution graph, but Load Workflow only read an authored workflow and reported the workflow as missing. Fall back to converting the saved graph into an editable workflow, matching legacy behavior and supporting existing images.

Preserve metadata inputs and execution flags, normalize historical image-collection and frame-count values, and keep conversion behind the lazy graph-preview entry.

QA Instructions

From invokeai/frontend/webv2:

  • pnpm lint — passed.
  • pnpm test — 10,448 tests passed on the final candidate.
  • pnpm test:browser — 2,969 tests passed. The initial run had an unrelated toast hover timeout; its 28 tests passed in isolation and the full browser rerun passed. The 62 image-action browser tests passed again after the final changes.
  • pnpm test:fixtures — passed.
  • pnpm test:performance:architecture — passed; production build budgets passed again after the compatibility fix. No baselines or budgets changed.
  • pnpm test:project-files:browser and pnpm test:accessibility:browser — passed.

Reproduction: generate an image, open its context menu, and choose Load Workflow. The editor should open the image's saved graph rather than report a missing workflow. Authored workflows still take precedence.

The final production build was also checked with isolated browser fixtures: Load Workflow opened both recalled nodes with the saved prompt and no page errors. No GPU generation was run.

Review

Resolved metadata-key safety, eager-loading, and historical graph-input compatibility issues. No material findings remain. Regression coverage checks graph conversion through serialization and compilation, malformed graphs, template failures, and account/project changes while loading.

Compatibility / Rollout

Uses the existing embedded graph and workflow API. No backend, queue, persisted-schema, or migration changes are required. Unavailable node types retain the existing best-effort conversion warning.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Meaningful regression coverage added / updated where needed; obsolete tests/code removed
  • Persisted-state and API changes include required migrations / compatibility validation
  • Relevant performance/efficiency opportunities considered; material claims have evidence
  • Material review findings resolved and relevant checks rerun
  • Documentation added / updated (if applicable) — affected loader and conversion contracts updated.
  • Updated What's New copy (if doing a release after this PR) — not a release.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Load saved generation graphs when images have no authored workflow.
Preserve metadata inputs and normalize historical node values on recall.
@github-actions github-actions Bot added the frontend PRs that change frontend files label Oct 18, 2026
@joshistoast
joshistoast enabled auto-merge (squash) October 18, 2026 02:58
@JPPhoto
JPPhoto self-requested a review October 18, 2026 03:03

@JPPhoto JPPhoto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@joshistoast
joshistoast merged commit de172fa into main Oct 18, 2026
16 checks passed
@joshistoast
joshistoast deleted the fix/generate-workflow-metadata branch October 18, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants