Repository navigation
fix(queue): identify rows by queue item ID - #9909
Merged
Merged
Conversation
Show localized item IDs in queue rows and keep prompts in expanded details. Preserve ID suffixes in narrow rows and cover metadata-free workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Queue widget rows now show the localized queue item ID, such as
Queue item #21, instead of prompt text or repeatedNo promptplaceholders. Prompts remain in expanded details. Identifier truncation preserves the suffix in narrow rows, and collapsed rows no longer extract prompt metadata.QA Instructions
Run commands from
invokeai/frontend/webv2with Node 22.14.0 and pnpm 10.pnpm test:browser src/features/queue/ui/QueueItemRow.browser.test.tsx: 8 passed, covering distinct metadata-free IDs and prompt disclosure.pnpm check:release: formatting, lint, types, architecture, and 10,448 unit tests passed. Chromium finished with 2,969 passing tests and one unrelated toast hover timeout after its button detached.pnpm test:browser src/platform/ui/theme/ToastContrast.browser.test.tsx: all 28 passed on isolated rerun.pnpm test:fixtures,pnpm test:performance:architecture,pnpm test:project-files:browser, andpnpm test:accessibility:browser: all passed, including 19 accessibility journeys.To reproduce, queue workflow items without prompt metadata and confirm each row has its own ID. Expand an item with prompt metadata and confirm its prompt remains visible. Chromium screenshots of collapsed workflow rows and expanded details were visually inspected. Full-app interactive inspection and attaching screenshots were unavailable because this session had no connected browser.
Review
No material findings. Changes are limited to queue-row presentation, its browser coverage, and removal of an unused English translation. The initial toast timeout is recorded above; no assertions or budgets were relaxed.
Checklist
What's Newcopy (if doing a release after this PR) (not applicable)Need help on this PR? Tag
@codesmith-botwith what you need.