Skip to content

fix(queue): identify rows by queue item ID - #9909

Merged
joshistoast merged 1 commit into
mainfrom
fix/queue-item-row-labels
Oct 18, 2026
Merged

joshistoast merged 1 commit into
mainfrom
fix/queue-item-row-labels

Conversation

@joshistoast

@joshistoast joshistoast commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Queue widget rows now show the localized queue item ID, such as Queue item #21, instead of prompt text or repeated No prompt placeholders. Prompts remain in expanded details. Identifier truncation preserves the suffix in narrow rows, and collapsed rows no longer extract prompt metadata.

QA Instructions

Run commands from invokeai/frontend/webv2 with Node 22.14.0 and pnpm 10.

  • pnpm test:browser src/features/queue/ui/QueueItemRow.browser.test.tsx: 8 passed, covering distinct metadata-free IDs and prompt disclosure.
  • pnpm check:release: formatting, lint, types, architecture, and 10,448 unit tests passed. Chromium finished with 2,969 passing tests and one unrelated toast hover timeout after its button detached.
  • pnpm test:browser src/platform/ui/theme/ToastContrast.browser.test.tsx: all 28 passed on isolated rerun.
  • pnpm test:fixtures, pnpm test:performance:architecture, pnpm test:project-files:browser, and pnpm test:accessibility:browser: all passed, including 19 accessibility journeys.

To reproduce, queue workflow items without prompt metadata and confirm each row has its own ID. Expand an item with prompt metadata and confirm its prompt remains visible. Chromium screenshots of collapsed workflow rows and expanded details were visually inspected. Full-app interactive inspection and attaching screenshots were unavailable because this session had no connected browser.

Review

No material findings. Changes are limited to queue-row presentation, its browser coverage, and removal of an unused English translation. The initial toast timeout is recorded above; no assertions or budgets were relaxed.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Meaningful regression coverage added / updated where needed; obsolete tests/code removed
  • Persisted-state and API changes include required migrations / compatibility validation (not applicable)
  • Relevant performance/efficiency opportunities considered; material claims have evidence
  • Material review findings resolved and relevant checks rerun
  • Documentation added / updated (if applicable) (not applicable)
  • Updated What's New copy (if doing a release after this PR) (not applicable)

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Show localized item IDs in queue rows and keep prompts in expanded details.
Preserve ID suffixes in narrow rows and cover metadata-free workflows.
@github-actions github-actions Bot added the frontend PRs that change frontend files label Oct 18, 2026
@joshistoast
joshistoast requested a review from JPPhoto October 18, 2026 03:33
@joshistoast
joshistoast enabled auto-merge (squash) October 18, 2026 03:33

@JPPhoto JPPhoto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@joshistoast
joshistoast merged commit 0f1ac66 into main Oct 18, 2026
16 checks passed
@joshistoast
joshistoast deleted the fix/queue-item-row-labels branch October 18, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend PRs that change frontend files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants