Repository navigation
feat(models): calibrate VAE working memory per model from the Model Manager - #9910
Draft
Pfannkuchensack wants to merge 41 commits into
Draft
Pfannkuchensack wants to merge 41 commits into
Pfannkuchensack wants to merge 41 commits into
Conversation
Runs each installed model family through a launched scratch server and compares PSNR, time and driver-level VRAM against accepted references. Graphs come from the frontend builders via an offline graph export; the generate submission plan is shared with the workbench.
VAE estimators return a WorkingMemoryEstimate built from fitted and analytic terms; model_on_device accepts it as working_memory=. The AutoencoderKL coefficients and their measured points move to backend/working_memory/data, checked by a data test; reservations are unchanged.
A probe records each estimated model_on_device window's device-level demand inside a calibration scope; results go to a per-device-class store under databases/working_memory. Admin endpoints start, inspect, reset and export runs; the reserved queue origin is refused for ordinary enqueues.
VAE estimators price a measured slope and base per conv backend, allocator and dtype instead of scaling one bf16 constant by element size; CogView4 gets its own lines. SD/SDXL nodes and their estimate share one run-dtype rule; on ROCm Windows an SDXL fp32 1024² decode reserves 6.2 instead of 14.6 GB and the UNet stays resident.
A lower second reading at a measured size no longer tilts a fitted line, and points that include cast weight growth no longer fit one; two shipped lines move by under 1 %.
…n fact Environment ids now include windows, linux or other, so calibrations from different operating systems are kept apart; the OS build string moves to soft fact os_build.
… runs start --calibrate submits each case through the calibration endpoint and saves the store export per server lifetime; scripts/working_memory/build_shipped.py turns exports into probe points and refits. Probe points bound estimates from below only, and the builder refuses data that the shared bound rule rejects.
# Conflicts: # docs/src/content/docs/development/Architecture/model-manager.mdx
…anager Adds a working-memory section to the model detail: plan, calibrate, stop and reset per GPU, with the measured, built-in and calibrated estimate per size. User fits from finished calibration attempts price VAE decodes within their measured range (+10 % + 256 MiB on the fitted part) and never below built-in values above it. New plan and summary routes; summary reports lines shared with other models and returns 404 for unknown models.
…calibration Judges allocator fragmentation per calibration attempt with one rule shared with the shipped-data builder, and moves other models off the GPU before a measured calibration lock. User fits use the shipped 5 % margin; the plan sizes cases from the capacity the cache will grant, including memory the driver keeps after earlier runs. The table marks uncounted sizes with their reason and explains each value column.
# Conflicts: # invokeai/backend/util/vae_working_memory.py # tests/app/invocations/test_flux2_working_memory.py
# Conflicts: # invokeai/backend/util/vae_working_memory.py
Main added useNsfwChecker and useWatermark to the generation project settings; exported calibration and E2E graphs run without both, as the defaults do.
…ser-calibration # Conflicts: # invokeai/frontend/webv2/performance/browser-baseline.json # invokeai/frontend/webv2/scripts/mock-backend-fixtures.test.mjs # invokeai/frontend/webv2/scripts/mock-backend.mjs
…e baseline Raises otherRawBytes to the measured 215114 B on every route; the 3791 B growth are the Model Manager working-memory strings.
…f the model page The section starts collapsed and shows the GPU with the calibration state, or the run progress, in its header; the plan loads on first open. The mock prices sizes above the measured range with the larger of the user line and built-in, as the server does.
6 of 7 tasks
# Conflicts: # docs/src/content/docs/development/Architecture/model-manager.mdx # invokeai/backend/model_manager/load/load_base.py
# Conflicts: # docs/src/content/docs/development/Architecture/model-manager.mdx # invokeai/backend/util/vae_working_memory.py # invokeai/backend/working_memory/coefficients.py # invokeai/backend/working_memory/data/vae.json # invokeai/backend/working_memory/platform.py # scripts/calibrate_flux2_working_memory.py # tests/app/invocations/test_flux2_working_memory.py # tests/app/invocations/test_vae_working_memory_backend.py # tests/app/invocations/test_z_image_tiled_decode.py # tests/backend/util/test_rocm_sdpa_head_dim_guard.py # tests/backend/working_memory/test_shipped_coefficients.py
6 of 7 tasks
# Conflicts: # invokeai/app/services/invocation_services.py
…ser-calibration # Conflicts: # invokeai/frontend/webv2/performance/browser-baseline.json # invokeai/frontend/webv2/scripts/mock-backend-fixtures.test.mjs # invokeai/frontend/webv2/scripts/mock-backend.mjs
…e baseline Raises otherRawBytes to the measured 224640 B on every route; the 3791 B growth are the Model Manager working-memory strings.
6 of 7 tasks
… tests CPU wheels on macOS and Windows have no CUDA allocator binding, so the fixture that scripts a CUDA build scripts its backend too.
…s a CUDA environment The refused-environment test scripted the CUDA build but asked the CPU wheel's missing allocator binding.
…ackage The calibration plan imported a facet module and the registry directly, which the architecture layering check refuses.
This was referenced Oct 19, 2026
[bug]: session-processor cancel/retry tests intermittently never see the canceled status on CI
#9948
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shipped VAE working-memory estimates come from a few reference GPUs. A user's card, driver or allocator can need less, or more. Admins can now calibrate a model's VAE decode on their own GPU from the Model Manager, and estimates on that GPU then use the measurement.
Model detail, "Working memory" section (actions are admin-only)
Estimates
device_working_mem_gb), nothing changes.Robustness found in hardware runs
invokeai/backend/working_memory/fragmentation.py).Before/after on an RX 9060 XT (SDXL, fp32 decode)
Related Issues / Discussions
QA Instructions
Tests
uv run --no-sync pytest -n 4: 4818 passed, 158 skipped, 5 xfailed. Covered: working-memory backend, calibration service, router and runner, session processor,tests/backend/model_manager/load,tests/app/invocations, the builder,tests/family_e2e.uv tool run ruff@0.11.2 checkandformat --check.make frontend-openapi/frontend-typegenequivalent);pnpm lintandpnpm testininvokeai/frontend/api.pnpm build(format, oxlint, tsc, architecture);src/features/models255;node --test scripts/mock-backend-fixtures.test.mjs28;pnpm test:performance:architecturepasses.pnpm testhere: 3 failures from the de-DE locale of this machine (number formatting) and 2 load timeouts that pass alone. All unrelated.Mutation checks, each caught:
Hardware, SDXL from the UI (18 runs per attempt) on an RTX 4090 (CUDA,
cudaMallocAsync) and an RX 9060 XT (ROCm 10, Windows, expandable segments):Browser
pnpm dev:mock; fault scenarios throughPOST /__faults) and on both real servers.Not verified on hardware: the Linux NVIDIA/AMD, MPS and XPU counter readers. The UI marks them as unverified.
Review
Resolved material findings
Remaining limits
Compatibility / Rollout
<db_dir>/working_memory/comes from feat(working-memory): measure working memory in admin calibration runs #9897. New optional fields (attempt_id, runsoft) are left out when absent, so older files load. No database migration.GET /api/v2/models/i/{key}/working_memory/planand/summary(404 for unknown models).attempt_idon calibrate. Line fieldsmeasured_by,own_windows, and size fieldscounted,excluded_reason. Generatedopenapi.jsonandschema.tsare updated.browser-baseline.jsonrecords the measuredotherRawBytes(215114 B on every route, main 211323 B); nothing else in the baseline changed.Checklist
What's Newcopy (if doing a release after this PR)