Repository navigation
Add public and shared Library workflows - #9952
Conversation
936a962 to
e83fb0d
Compare
847cbdc to
7e20bf6
Compare
Read category from nested workflow metadata and carry the record owner through Library open and publication paths.
Keep pending and result feedback scoped per workflow. Fence responses by request identity and account scope.
7e20bf6 to
f777a4b
Compare
Keep both workflow visibility and upstream gallery fixture coverage.
Merge origin/main through ef2be36 while preserving public workflow ownership and visibility behavior. Keep sort preferences and linked-template relink guidance with the publication flow.
…ches/277558-1792718890/f5cbdbcf35d53c0df608b2019e278db7f1df6b39
…ches/315837-1792728851/f5cbdbcf35d53c0df608b2019e278db7f1df6b39
|
Something to add to this PR is some feedback I got from @lstein on issue #9673
Can we fold this in here? I'd probably only allow this for admins of course. Also...
Maybe we fold that in also? |
Reconcile rejected visibility writes against server state and provide retry when readback fails. Allow ready multi-user admins to update saved non-bundled templates while keeping visibility controls owner-only. Correct the linked workflow CI fixture and update user guidance.
|
@joshistoast I pushed I reconciled rejected visibility writes with server readback in I verified 75 affected browser tests, 10,844 unit tests, accessibility journeys (19/19), the project-file browser journey, performance browser/build gates, and lint/typecheck. The full browser suite passed at --maxWorkers=4; the default-concurrency release run reported three unrelated timing flakes. |
Keep upstream performance ownership data and hosted-provider fixture coverage alongside the workflow changes.
Keep the revision returned by creation when visibility succeeds or is retried.
Summary
In multi-user mode, owners can set saved Library workflows to Private or Public from the Yours tab. Public workflows appear in Shared and remain callable from compatible workflow nodes. Save to Library can create a public Library copy. Public means visible to signed-in users of the same InvokeAI instance.
Other users can open, duplicate, or download public workflows. Only the owner can rename, delete, or change visibility. A ready multi-user administrator can update any user's saved non-bundled template through Update Template; bundled templates remain read-only. Visibility applies to the Library copy, not the project workflow.
When a visibility update response is uncertain, the detail panel reconciles from the server. If readback fails, it shows Visibility unknown and offers Retry.
Related Issues / Discussions
This PR closes #9673.
QA Instructions
Run from
invokeai/frontend/webv2:pnpm test src/features/workflow/data/publication.test.tspassed (12/12),WorkflowPublicationHost.browser.test.tsxpassed (23/23), andpnpm lint:codepassed. Full unit and browser suites were not rerun after this follow-up.pnpm lint:code- passed formatting, oxlint, Chakra type generation, and TypeScript checks.pnpm test- passed: 10,844 unit tests.--maxWorkers=4. After the final visibility fixes, the 75 affected browser tests passed. The default-concurrency release browser stage reported three timing flakes in ModelManagerDrafts, FeatureHint, and ToastContrast.pnpm run test:accessibility:browser- passed (19/19).pnpm run test:project-files:browser- passed.pnpm run test:fixtures- passed (47/47).pnpm run test:performance:browserandpnpm run test:performance:build- passed. The browser baseline was recaptured with the documented full profile; route IDs, request counts, and source-owner sets did not change.pnpm run architecture:inventory- passed.Review
Independent reviews found no outstanding material findings. Review findings were resolved with regression coverage. Older multi-user project links without owner metadata fail closed for Update Template until reopened from the Library.
Compatibility / Rollout
No migration or generated API contract change is needed; the frontend uses the existing visibility endpoint. Single-user behavior remains unchanged. Visibility changes affect the Library record only.
Checklist
What's Newcopy (if doing a release after this PR)Need help on this PR? Tag
@codesmith-botwith what you need.