Repository navigation
Clarify and improve 2025/yang1/try.sh - #301
Merged
Merged
Conversation
(If Don Yang disagrees with any of this I am quite fine in not having this btw). The script now checks if ruby is installed prior to running the ruby commands. The same is done for perl. (Both use type -P). The message that says '0 to quit' might suggest to quit the script but it does not. In fact it means to move to the next step so it now says 'to go to the next step'. This should help clarify what is happening and it might also (though not completely and very possibly not - maybe this should be added as a little notice before?) help users see that it's looping with the same procedure until one enters 0 (at the appropriate prompt). The 'to go to next step' might also help people who are not paying attention or who are sleeping (or not awake enough).
Contributor
Author
|
BTW the changelog here in pull requests always seems to add at the end: # Making a pull request
Please see the FAQ on "[making a pull request](faq.html#pull_request)".I do not know why and I am not able to look into it bu you might want to know Landon. Hope you're well ... doing other things now. I think this is the first time I have looked at any entry from 2025 (minus mine) although I might have briefly looked at some! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(If Don Yang disagrees with any of this I am quite fine in not having this btw).
The script now checks if ruby is installed prior to running the ruby commands. The same is done for perl. (Both use type -P).
The message that says '0 to quit' might suggest to quit the script but it does not. In fact it means to move to the next step so it now says 'to go to the next step'. This should help clarify what is happening and it might also (though not completely and very possibly not - maybe this should be added as a little notice before?) help users see that it's looping with the same procedure until one enters 0 (at the appropriate prompt). The 'to go to next step' might also help people who are not paying attention or who are sleeping (or not awake enough).