Add eligibility group memberships to operator api#733
Open
tie-ioki wants to merge 2 commits into
Open
Conversation
phylor
approved these changes
Jun 14, 2026
| module Model | ||
| module Operator | ||
| class EligibilityGroupMembership < Base | ||
| attribute :email_address, |
Collaborator
There was a problem hiding this comment.
This model is a bit convoluted. It combines the schema used in the POST request with the response serializer. We usually only do that if both are named identically and match conceptually (e.g. POST User schema returns a User). In this context, it seems the two models are conceptually different.
Personally I'd split them up:
Ioki::Model::Operator::EligibilityGroupMembershipManuallyAssignByEmailAddressIoki::Model::Operator::EligibilityGroupMembership
You should be able to set the schema as outgoing_model_class in the endpoint configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.