Repository navigation
fix(android): resolve the JS engine AAR without a postinstall script - #177
Open
theproducer wants to merge 3 commits into
Open
theproducer wants to merge 3 commits into
theproducer wants to merge 3 commits into
Conversation
theproducer
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This plugin relied on npm's
postinstallscript to patch aflatDirrepository into the consuming app'sandroid/app/build.gradle. npm 12 blocks dependency lifecycle scripts by default, this approach will eventually stop working.This PR resolves this problem by using the AAR as a local file dependency.
Change Type
Rationale / Problems Fixed
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments