chore(api): generate heading IDs with MDX comment syntax - #4639
Open
thetaPC wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
The component API plugin generates heading IDs using the classic
{#my-id}syntax:spinner {#prop-spinner}Docusaurus calls this "proprietary Docusaurus syntax, leading to ecosystem incompatibilities" and recommends the native MDX comment form instead.. We migrated our hand written docs off this syntax in #4628, but the plugin kept emitting it, so it comes back on every build. On
mainthat is 1435 headings across 910 generated partials (1263 property headings, 172 method headings).What is the new behavior?
The plugin emits the MDX comment form:
spinner {/* #prop-spinner */}Two lines change, one for properties and one for methods, which covers all 1435 headings. No other partial type is affected: events, parts, slots and custom-props contain tables rather than headings.
Does this introduce a breaking change?
Other information
Part of the mdx migration.
No anchors change. Both syntaxes produce the same id, so
#prop-spinner,#method-dismissand every other API anchor continue to resolve.How to test
Check that each heading renders its name only, with no visible
{/* ... */}text, and that both the anchor link and the table of contents entry jump to it.spinnerheading should link to#prop-spinnerdismissheading should link to#method-dismissaccept (deprecated)should link to#prop-accept(deprecated)interpolation on the same lineconfirmandcancelmethods" has two links