Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1492
The t8n state-transition path stored block timestamps as signed int64_t values. Inputs above 2^63-1 could wrap before the pre-Merge difficulty calculation, diverging from other execution clients.
This change keeps BlockInfo timestamps and the difficulty API unsigned, loads currentTimestamp and parentTimestamp as uint64_t, and bounds the signed difficulty adjustment without narrowing the timestamp delta.
The change is limited to the test-transition tooling and preserves existing behavior for ordinary timestamps.
Tests and builds were not run locally; this contribution was prepared through GitHub's web editor.