state: Widen the blob fee in the affordability check - #1714
Merged
Merged
Conversation
The blob part of the maximum transaction cost was multiplied in uint256, so with one blob and a max_fee_per_blob_gas of 2^239 the product wrapped to zero and the transaction passed the balance check it should have failed. Multiply into 512 bits like the gas part. Fixes ipsilon#1480
There was a problem hiding this comment.
🟢 Approval recommended
The fix correctly matches existing wide-precision fee calculation and includes a focused regression test.
Pull request overview
Fixes blob transaction affordability validation by preventing 256-bit multiplication overflow.
Changes:
- Computes maximum blob fees using 512-bit multiplication.
- Adds a regression test for the reported overflow case.
File summaries
| File | Description |
|---|---|
test/state/state.cpp |
Widens blob fee multiplication. |
test/unittests/state_transition_tx_test.cpp |
Tests rejection of an unaffordable overflowing blob fee. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blob part of the maximum transaction cost was multiplied in uint256, so with one blob and a max_fee_per_blob_gas of 2^239 the product wrapped to zero and the transaction passed the balance check it should have failed. It is now multiplied into 512 bits like the gas part, which is what the comment above already promised.
The new state_transition test is the issue's reproducer. Without the fix it gets past validation and trips the blob fee assert in transition on a debug build.
Fixes #1480