Conversation
go-ethereum's transaction JSON names a typed transaction's signature recovery id yParity, and the evm t8n tool accepts it without v. The evmone loaders required v unconditionally, so such a txs.json failed to load. Take yParity for typed transactions when it is given, and reject a v alongside it that disagrees, the rule go-ethereum applies. Legacy transactions keep v, which also carries the chain id. Fixes ipsilon#1488
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-ethereum's transaction JSON names a typed transaction's recovery id yParity and its t8n accepts it without v, while both evmone loaders required v and failed on the txs.json from the issue. Typed transactions now take yParity when it is given, and a v alongside it that disagrees is rejected, which is the rule go-ethereum applies. Legacy transactions keep v since it also carries the chain id.
The issue's txs.json is added as a t8n case (the tx hash it computes matches the one in the report), plus a loader unit test for the four combinations. Both fail on master.
Fixes #1488