test: Count deselected files apart from skipped ones - #1716
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Separates deselected fixture files from skipped files in test reporting while preserving exit code 5 when nothing runs.
Changes:
- Adds deselected outcome tracking and summary reporting.
- Updates unit tests for deselection behavior.
- Adds CLI integration coverage for filtering scenarios.
File summaries
| File | Description |
|---|---|
test/utils/test_driver.hpp |
Defines the deselected outcome. |
test/utils/test_driver.cpp |
Classifies, reports, and counts deselected files. |
test/unittests/test_driver_test.cpp |
Tests deselection behavior. |
test/integration/evmone-cli/test/CMakeLists.txt |
Adds CLI integration tests. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
A file whose fixtures were all filtered out by -k is the one case where run_fixture_file() returns no result. It was counted as skipped, which is the bucket for a file the tool could not run. Now it is reported as deselected, as pytest does, and neither listed nor allowed to count as verified.
chfast
force-pushed
the
1703-deselected
branch
from
September 15, 2026 19:24
5e7e40f to
33e4935
Compare
| passed = '.', | ||
| failed = 'F', | ||
| skipped = 's', | ||
| deselected = 'd', ///< A file whose fixtures were all filtered out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1703.
A file whose fixtures were all filtered out by -k was counted as skipped. It is the one case where run_fixture_file() returns no result, so the driver now counts it as deselected and reports it after skipped in the summary, as pytest does. Skipped keeps its meaning, deselected files are not listed, and a run which selected nothing still exits 5.
The progress row prints d for such a file. The driver test that pinned 0 passed, 1 skipped now pins 1 deselected, and two integration tests cover the -k no_such_name case from the issue, one of them beside skipped files.