Preserve async shell context across cells - #1548
Open
fff122 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #749
Summary
The asynchronous cell runner created a separate task for the cell coroutine. ContextVar updates made after an
awaittherefore remained in that task and were not available to the next execute request. The SIGINT cancellation hook also tracked the separate task.This change runs the cell coroutine in the current execute task while retaining the cancellation hook, and persists the resulting async context for subsequent requests. The regression test sets a ContextVar after an await and verifies that the value is available in the next cell.
Validation
ipyparalleltest dependencygit diff --checkpassed