Drop type:ignore comments made unused by argcomplete 3.7 - #973
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This diff only edits Making that check green would mean adding a test whose only purpose is to exercise a line this PR doesn't touch the behaviour of. Happy to do it if you'd rather have the check green than the diff minimal — just say so. Generated by Claude Code |
argcomplete 3.7 ships inline annotations for split_line(), debug() and CompletionFinder.__call__, so the no-untyped-call ignores around those calls are now reported as unused-ignore and the lint job fails. Remove the stale codes and floor the mypy hook's argcomplete at 3.7 so the check behaves the same locally and in CI.
2494e22 to
7d21876
Compare
Summary
The
Test Lintjob onmainhas been failing: argcomplete 3.7 ships inline annotations forsplit_line(),debug()andCompletionFinder.__call__, so theno-untyped-callignores around those calls are now reported asunused-ignoreand mypy exits non-zero.(For the record,
packagingwas not involved — I confirmed the suite passes withpackaging26.3, and reverting argcomplete to 3.6.2 makes mypy clean again.)Changes
no-untyped-callcode from three ignores intraitlets/config/argcomplete_config.py(theattr-definedcode is still needed and stays).ExtendedCompletionFinder()intraitlets/config/loader.py.argcompletedependency at>=3.7(was>=3.1), so the check means the same thing locally and in CI — on an older argcomplete the ignores would be required again.The
no-untyped-callignores onsuper()._get_completions/_get_option_completionsare untouched: those private methods are still unannotated.Verification
mypy clean over 24 source files and 706 tests passing against argcomplete 3.7.2.
Test Lintis green on this branch.https://claude.ai/code/session_0141ZmpAbm5FVsds8iNEotpp