[#267] Do not allow other plugins to invoke register_regexes_from_array (main) - #268
Open
korydraughn wants to merge 1 commit into
Open
korydraughn wants to merge 1 commit into
korydraughn wants to merge 1 commit into
Conversation
korydraughn
force-pushed
the
267.m
branch
2 times, most recently
from
September 15, 2026 20:02
b385c9f to
83ecd23
Compare
This commit moves the register_regexes_from_array function into a nearby anonymous namespace.
Contributor
Author
|
Running core tests against irods/irods#9080. The irods/irods PR doesn't change any server functionality, so running against it is the same as testing against tip of main irods/irods. It also means we get to run this PR against the core test suite with the new test added by the irods/irods PR. |
Contributor
Author
|
All core tests passed except the following:
I'm pretty sure the failures have nothing to do with this PR. Investigating now. |
MartinFlores751
left a comment
MartinFlores751
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Don't forget to leave a comment about your findings on the test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to irods/irods#9078.
This PR moves the mentioned function into a nearby anonymous namespace.
Will run tests soon.