Skip to content

fix: dispose HTTP batch server sessions - #2

Draft
irvinebroque wants to merge 1 commit into
mainfrom
codex/http-batch-session-cleanup
Draft

fix: dispose HTTP batch server sessions#2
irvinebroque wants to merge 1 commit into
mainfrom
codex/http-batch-session-cleanup

Conversation

@irvinebroque

@irvinebroque irvinebroque commented Sep 5, 2026

Copy link
Copy Markdown
Owner

An HTTP batch is a one-time conversation. When its response is ready, the server should close the conversation and release the objects it used. Today, successful batches can leave that cleanup undone.

The TODO predates the mechanism this patch uses:

This patch makes that connection. Both handlers dispose the main stub in finally, after waiting for requested results and capturing the response. Cleanup also runs on failure. It reuses session shutdown rather than introducing another disposal mechanism.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Brendan Irvine-Broque seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant