fix: share nested RPC validators within a module - #3
Draft
irvinebroque wants to merge 2 commits into
Draft
Conversation
|
I have read the CLA Document and I hereby sign the CLA Brendan Irvine-Broque seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An API can return several objects with the same interface. Today, the validation compiler copies their rules into every place they are used, making generated bundles unnecessarily large.
This patch emits each distinct service validator once per module and reuses it. Server and client rules stay separate. Sharing compares the actual referenced type definitions, so two services called
Sharedcannot accidentally share string checks when one expects numbers.Registration and emission live together in one focused module. Six regression tests cover reuse, recursive references, different contracts, and runtime rejection of invalid values. All 617 Node and Workers tests, build, type checks, and Markdown lint pass.
The package README, validation guide, and patch changeset are updated. No application changes are required.